Skip to content

Clean global scope in all controllers. #980

@NitayRabi

Description

@NitayRabi

Overview of the problem

We have several functions declared globally in controller files.
This can create issues hard to anticipate and solve.

Description

  1. We need to move all functions into scope.
    image
    image
  2. We need to make sure the functions aren't used in any other file (if so, we should create an AngularJS service to be shared between the controllers)
  3. Sanity after the cleanup - check most screens and buttons don't raise exceptions related to missing functions.

Expected behavior

Functions should be scoped

Actual behavior

Functions are declared outside of AngularJS's controllers call back

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions