-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add export fleet CSV endpoint to URLs #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shay-coding
wants to merge
1
commit into
main
Choose a base branch
from
shay-coding-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the URL pattern to match existing vehicle routes.
The URL pattern has an inconsistent
operator/prefix that doesn't match other vehicle-related routes in this file. All existing vehicle URLs follow the pattern<str:operator_slug>/vehicles/...(lines 88-99), but this new route usesoperator/<str:operator_slug>/vehicles/....This inconsistency will result in a URL like
/operator/my-operator/vehicles/export/instead of the expected/my-operator/vehicles/export/, breaking the established URL structure.🔧 Proposed fix to align with existing URL pattern
📝 Committable suggestion
🧰 Tools
🪛 Ruff (0.14.10)
100-100:
export_fleet_csvmay be undefined, or defined from star imports(F405)
🤖 Prompt for AI Agents
🧩 Analysis chain
🏁 Script executed:
Repository: NextStopLabs/MyBusTimes
Length of output: 229
🏁 Script executed:
Repository: NextStopLabs/MyBusTimes
Length of output: 3437
Implement the missing
export_fleet_csvview infleet/views.py.The view function is referenced in
fleet/urls.pyat line 100 but does not exist infleet/views.py. This will cause a runtime error when the endpoint is accessed. Add the view function tofleet/views.pybefore merging.🧰 Tools
🪛 Ruff (0.14.10)
100-100:
export_fleet_csvmay be undefined, or defined from star imports(F405)