Skip to content

Minor performance improvements to PowerElectronics residual evaluation #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelesh merged 4 commits into from
Jan 9, 2026
Merged

Minor performance improvements to PowerElectronics residual evaluation #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
962646c
Change connection_nodes_ to be an array
alexander-novo Jan 8, 2026
7264456
Add final and const to various functions in PE
alexander-novo Jan 8, 2026
03e1993
Perform manual LICM on some hot loops in PowerElectronicsModel
alexander-novo Jan 8, 2026
cefbb7c
Update CHANGELOG
alexander-novo Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
- Added a header file defining common math functions (e.g., sigmoid) to be used throughout the code.
- Added capability to print monitored variables in multiple formats, triggered from `Ida::runSimulation`.
- Added IDA statistics object which can be accumulated over multiple simulations.
- Minor performance improvements to residual evaluation in PowerElectronics module.

## v0.1

Expand Down
119 changes: 77 additions & 42 deletions GridKit/Model/PowerElectronics/CircuitComponent.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,20 @@ namespace GridKit
using RealT = typename Model::Evaluator<ScalarT, IdxT>::RealT;
using MatrixT = typename Model::Evaluator<ScalarT, IdxT>::MatrixT;

CircuitComponent() = default;
~CircuitComponent() = default;
CircuitComponent() = default;

void updateTime(RealT t, RealT a)
~CircuitComponent()
{
if (connection_nodes_ != nullptr)
{
delete[] connection_nodes_;
}
};

/**
* @note Cannot be marked final, since it is overriden to recurse in the system model.
*/
void updateTime(RealT t, RealT a) override
{
this->time_ = t;
this->alpha_ = a;
Expand Down Expand Up @@ -59,6 +69,11 @@ namespace GridKit
*/
int setExternalConnectionNodes(IdxT local_index, IdxT global_index)
{
if (connection_nodes_ == nullptr)
{
connection_nodes_ = new IdxT[size_];
}

connection_nodes_[local_index] = global_index;
return 0;
}
Expand All @@ -71,185 +86,205 @@ namespace GridKit
* @param local_index index of local value in vector
* @return IdxT Index of the same value in the global vector
*/
IdxT getNodeConnection(IdxT local_index)
IdxT getNodeConnection(IdxT local_index) const
{
return connection_nodes_.at(local_index);
return connection_nodes_[local_index];
}

public:
virtual IdxT size()
IdxT size() final
{
return size_;
}

virtual IdxT nnz()
IdxT size() const
{
return size_;
}

IdxT nnz() final
{
return nnz_;
}

virtual IdxT sizeQuadrature()
IdxT nnz() const
{
return nnz_;
}

IdxT sizeQuadrature() final
{
return size_quad_;
}

IdxT sizeQuadrature() const
{
return size_quad_;
}

virtual IdxT sizeParams()
IdxT sizeParams() final
{
return size_opt_;
}

IdxT sizeParams() const
{
return size_opt_;
}

virtual void setTolerances(RealT& rel_tol, RealT& abs_tol) const
void setTolerances(RealT& rel_tol, RealT& abs_tol) const final
{
rel_tol = rel_tol_;
abs_tol = abs_tol_;
}

virtual void setMaxSteps(IdxT& msa) const
void setMaxSteps(IdxT& msa) const final
{
msa = max_steps_;
}

std::vector<ScalarT>& y()
std::vector<ScalarT>& y() final
{
return y_;
}

const std::vector<ScalarT>& y() const
const std::vector<ScalarT>& y() const final
{
return y_;
}

std::vector<ScalarT>& yp()
std::vector<ScalarT>& yp() final
{
return yp_;
}

const std::vector<ScalarT>& yp() const
const std::vector<ScalarT>& yp() const final
{
return yp_;
}

std::vector<bool>& tag()
std::vector<bool>& tag() final
{
return tag_;
}

const std::vector<bool>& tag() const
const std::vector<bool>& tag() const final
{
return tag_;
}

std::vector<ScalarT>& yB()
std::vector<ScalarT>& yB() final
{
return yB_;
}

const std::vector<ScalarT>& yB() const
const std::vector<ScalarT>& yB() const final
{
return yB_;
}

std::vector<ScalarT>& ypB()
std::vector<ScalarT>& ypB() final
{
return ypB_;
}

const std::vector<ScalarT>& ypB() const
const std::vector<ScalarT>& ypB() const final
{
return ypB_;
}

std::vector<ScalarT>& param()
std::vector<ScalarT>& param() final
{
return param_;
}

const std::vector<ScalarT>& param() const
const std::vector<ScalarT>& param() const final
{
return param_;
}

std::vector<ScalarT>& param_up()
std::vector<ScalarT>& param_up() final
{
return param_up_;
}

const std::vector<ScalarT>& param_up() const
const std::vector<ScalarT>& param_up() const final
{
return param_up_;
}

std::vector<ScalarT>& param_lo()
std::vector<ScalarT>& param_lo() final
{
return param_lo_;
}

const std::vector<ScalarT>& param_lo() const
const std::vector<ScalarT>& param_lo() const final
{
return param_lo_;
}

std::vector<ScalarT>& getResidual()
std::vector<ScalarT>& getResidual() final
{
return f_;
}

const std::vector<ScalarT>& getResidual() const
const std::vector<ScalarT>& getResidual() const final
{
return f_;
}

MatrixT& getJacobian()
MatrixT& getJacobian() final
{
return jac_;
}

const MatrixT& getJacobian() const
const MatrixT& getJacobian() const final
{
return jac_;
}

std::vector<ScalarT>& getIntegrand()
std::vector<ScalarT>& getIntegrand() final
{
return g_;
}

const std::vector<ScalarT>& getIntegrand() const
const std::vector<ScalarT>& getIntegrand() const final
{
return g_;
}

std::vector<ScalarT>& getAdjointResidual()
std::vector<ScalarT>& getAdjointResidual() final
{
return fB_;
}

const std::vector<ScalarT>& getAdjointResidual() const
const std::vector<ScalarT>& getAdjointResidual() const final
{
return fB_;
}

std::vector<ScalarT>& getAdjointIntegrand()
std::vector<ScalarT>& getAdjointIntegrand() final
{
return gB_;
}

const std::vector<ScalarT>& getAdjointIntegrand() const
const std::vector<ScalarT>& getAdjointIntegrand() const final
{
return gB_;
}

//@todo Fix ID naming
IdxT getIDcomponent()
IdxT getIDcomponent() const
{
return idc_;
}

protected:
size_t n_extern_;
size_t n_intern_;
std::set<IdxT> extern_indices_;
size_t n_extern_;
size_t n_intern_;
std::set<IdxT> extern_indices_;
///@todo may want to replace the mapping of connection_nodes to Node objects instead of IdxT. Allows for container free setup
std::map<IdxT, IdxT> connection_nodes_;
IdxT* connection_nodes_ = nullptr;

protected:
IdxT size_{0};
Expand Down
Loading
Loading