Is the Section trigger effect set up properly?

[BLesnau]

In processTrigger(), the code for the Continuous trigger effect looks like this:

DualSense-Windows/VS19_Solution/DualSenseWindows/src/DualSenseWindows/DS5_Output.cpp

Lines 43 to 50 in 0b869f4

	case DS5W::TriggerEffectType::ContinuousResitance:
	// Mode
	buffer[0x00] = 0x01;
	// Parameters
	buffer[0x01] = ptrEffect->Continuous.startPosition;
	buffer[0x02] = ptrEffect->Continuous.force;
	break;

And the code for the Section trigger effect looks like this:

DualSense-Windows/VS19_Solution/DualSenseWindows/src/DualSenseWindows/DS5_Output.cpp

Lines 53 to 60 in 0b869f4

	case DS5W::TriggerEffectType::SectionResitance:
	// Mode
	buffer[0x00] = 0x02;
	// Parameters
	buffer[0x01] = ptrEffect->Continuous.startPosition;
	buffer[0x02] = ptrEffect->Continuous.force;
	break;

The Section trigger effect sets the first part of the array to a different value, which probably makes it do the Section effect rather than the Continuous effect, but the rest of that code actually uses the values from the Continuous effect.

The value for the end position should be put somewhere, correct?

Also, shouldn't the struct for the Section effect contain a value for the force to be used?

[AliElSaleh]

Technically, it is setup properly. Because the trigger effect types are all wrapped in a union, meaning all members in the struct will share the same memory space, think of it as structs overlaying over each other. So startPosition of struct Continuous would have the same value as startPosition of struct Section, due to how it's laid out in the structs. But of course, it should still use the Section struct, for readability.

And yeah a force parameter for the Section type would be useful as well.