From b79f3dc05b9fa721676524cc7732cab2289b15e6 Mon Sep 17 00:00:00 2001 From: David Feltell Date: Tue, 30 Sep 2025 10:51:13 +0100 Subject: [PATCH 1/3] [CI] Re-enable backward compatibility check Revert "[CI] Disable backward compatibility check" This reverts commit ab9ad28d0476f03a4289dd62486ce402d8cd3c2f. The check was disabled on the initial commit, since there was no history to diff against, so the check failed. Signed-off-by: David Feltell --- .github/workflows/{validate.yml.disabled => validate.yml} | 1 - 1 file changed, 1 deletion(-) rename .github/workflows/{validate.yml.disabled => validate.yml} (82%) diff --git a/.github/workflows/validate.yml.disabled b/.github/workflows/validate.yml similarity index 82% rename from .github/workflows/validate.yml.disabled rename to .github/workflows/validate.yml index 21d89b9..b273847 100644 --- a/.github/workflows/validate.yml.disabled +++ b/.github/workflows/validate.yml @@ -2,7 +2,6 @@ # Copyright (c) 2025 The Foundry Visionmongers Ltd # SPDX-License-Identifier: Apache-2.0 -# TODO(DF): Re-enable once initial PR merged to set a baseline. name: Validate backwards compatibility on: From c4b38c5a4b8427679f9bd728b27e53bae54be28e Mon Sep 17 00:00:00 2001 From: David Feltell Date: Tue, 30 Sep 2025 11:13:24 +0100 Subject: [PATCH 2/3] [CI] Install deps for backward compatibility check On re-enabling the backward compatibility check that came with the ComfyUI cookiecutter project, it failed due to missing dependencies (specifically pytorch). So install dependencies before running the action. Choose dependencies from the PR rather than main, in case they are different, in the spirit of testing backward compatibility. Signed-off-by: David Feltell --- .github/workflows/validate.yml | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index b273847..f57252b 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -14,4 +14,34 @@ jobs: validate: runs-on: ubuntu-latest steps: + # We cannot simply run the node-diff action, since it will try + # to import our package without installing dependencies. So we + # install dependencies ourselves first. + + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: "3.10" # Same as comfy-org/node-diff + + - name: Checkout PR + uses: actions/checkout@v4 + with: + path: pr_repo # Same as comfy-org/node-diff + + - uses: actions/checkout@v4 + name: Checkout ComfyUI + with: + repository: comfyanonymous/ComfyUI + ref: v0.3.57 + path: comfyui + + - name: Install dependencies + shell: bash + run: | + python -m pip install --upgrade pip + pip install ./pr_repo + pip install -r ./comfyui/requirements.txt + - uses: comfy-org/node-diff@main + env: + PYTHONPATH: ${{ github.workspace }}/comfyui From d2a2f2f8f018c601eac89c792b7df4092cbd48b6 Mon Sep 17 00:00:00 2001 From: David Feltell Date: Tue, 30 Sep 2025 11:20:05 +0100 Subject: [PATCH 3/3] [CI] Remove "master" from backward compatibility check We use `main` rather than `master`, so there's no need to check for PRs against `master`. Signed-off-by: David Feltell --- .github/workflows/validate.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index f57252b..26f7f6a 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -7,7 +7,6 @@ name: Validate backwards compatibility on: pull_request: branches: - - master - main jobs: