[UPD] spp_registry_name_suffix: add name suffix support for individuals

- Add spp.name.suffix model for configurable suffixes (Jr., Sr., III, PhD, etc.)
- Extend res.partner with suffix_id field and name_change method
- Add configuration menu under Registry > Configuration > Name Suffixes
- Include default suffix data and unit tests

Author: gonzalesedwin1123

spp_registry_name_suffix/__manifest__.py

@@ -3,15 +3,14 @@
     "name": "OpenSPP Registry Name Suffix",
     "summary": "Adds a configurable suffix field (Jr., Sr., III, etc.) to Individual registrant names in OpenSPP.",
     "category": "OpenSPP",
-    "version": "17.0.1.4.0",
+    "version": "17.0.1.4.1",
     "sequence": 1,
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/openspp-modules",
     "license": "LGPL-3",
     "development_status": "Beta",
     "maintainers": ["jeremi", "gonzalesedwin1123"],
     "depends": [
-        "spp_registrant_import",
         "g2p_registry_individual",
     ],
     "data": [

spp_registry_name_suffix/data/name_suffix_data.xml

@@ -51,26 +51,4 @@
         <field name="description">The Fifth</field>
     </record>
 
-    <!-- Academic/Professional Suffixes -->
-    <record id="suffix_phd" model="spp.name.suffix">
-        <field name="name">PhD</field>
-        <field name="code">PHD</field>
-        <field name="sequence">100</field>
-        <field name="description">Doctor of Philosophy</field>
-    </record>
-
-    <record id="suffix_md" model="spp.name.suffix">
-        <field name="name">MD</field>
-        <field name="code">MD</field>
-        <field name="sequence">110</field>
-        <field name="description">Doctor of Medicine</field>
-    </record>
-
-    <record id="suffix_esq" model="spp.name.suffix">
-        <field name="name">Esq.</field>
-        <field name="code">ESQ</field>
-        <field name="sequence">120</field>
-        <field name="description">Esquire - typically used for attorneys</field>
-    </record>
-
 </odoo>

spp_registry_name_suffix/models/res_partner.py

@@ -11,19 +11,9 @@ class ResPartner(models.Model):
         help="Name suffix such as Jr., Sr., III, IV, PhD, MD, etc.",
     )
 
-    @api.depends(
-        "is_registrant",
-        "is_group",
-        "family_name",
-        "given_name",
-        "addl_name",
-        "suffix_id",
-    )
-    def _compute_name(self):
-        """Extend name computation to include suffix for individuals."""
-        super()._compute_name()
-        for rec in self:
-            if not rec.is_registrant or rec.is_group:
-                continue
-            if rec.suffix_id:
-                rec.name = f"{rec.name}, {rec.suffix_id.name.upper()}"
+    @api.onchange("is_group", "family_name", "given_name", "addl_name", "suffix_id")
+    def name_change(self):
+        """Extend name change to include suffix for individuals."""
+        super().name_change()
+        if not self.is_group and self.suffix_id:
+            self.name = f"{self.name}, {self.suffix_id.name.upper()}"

spp_registry_name_suffix/readme/DESCRIPTION.md

@@ -8,7 +8,7 @@ This module enhances individual registrant data by:
 
 * **Providing configurable suffixes**: Administrators can manage available suffixes through the Registry Configuration menu.
 * **Adding suffix support**: Record name suffixes using a standardized Many2one field reference.
-* **Extending name generation**: Automatically includes the suffix in the computed full name.
+* **Extending name generation**: Automatically includes the suffix in the generated full name.
 * **Maintaining data integrity**: The suffix is stored as a reference to a configurable suffix record.
 
 ## Features
@@ -32,16 +32,15 @@ The suffix field appears on the Individual registrant form after the "Additional
 - Optional display in the registrant list view
 
 ### Automatic Name Generation
-The suffix is automatically appended to the registrant's computed name in the format:
-`FAMILY_NAME, GIVEN_NAME, ADDL_NAME, SUFFIX`
+The suffix is automatically appended to the registrant's name when using the form. The module extends the `name_change` method from `g2p_registry_individual` to include the suffix in the generated name format:
+`FAMILY_NAME, GIVEN_NAME ADDL_NAME, SUFFIX`
 
-For example: "SMITH, JOHN, MICHAEL, JR."
+For example: "SMITH, JOHN MICHAEL, JR."
 
 ## Dependencies
 
 This module depends on:
-- **spp_registrant_import**: Provides the base name computation logic for registrants.
-- **g2p_registry_individual**: Provides the individual registrant views and model.
+- **g2p_registry_individual**: Provides the individual registrant views, model, and the base `name_change` method.
 
 ## Configuration
 
@@ -58,4 +57,3 @@ This module depends on:
 ## References
 
 - OpenG2P Registry Individual: https://github.com/OpenSPP/openg2p-registry/tree/17.0-develop-openspp/g2p_registry_individual
-

spp_registry_name_suffix/tests/test_name_suffix.py

@@ -2,7 +2,7 @@
 
 from odoo.exceptions import ValidationError
 from odoo.tests import tagged
-from odoo.tests.common import TransactionCase
+from odoo.tests.common import Form, TransactionCase
 
 
 @tagged("post_install", "-at_install")
@@ -61,44 +61,50 @@ def test_02_suffix_uniqueness(self):
                 }
             )
 
-    def test_03_name_with_suffix(self):
-        """Test that suffix is appended to the computed name."""
-        individual = self.env["res.partner"].create(
-            {
-                "family_name": "Doe",
-                "given_name": "John",
-                "suffix_id": self.suffix_jr.id,
-                "is_registrant": True,
-                "is_group": False,
-            }
+    def test_03_name_with_suffix_using_form(self):
+        """Test that suffix is appended to the name using form simulation."""
+        with Form(self.env["res.partner"]) as partner_form:
+            partner_form.is_registrant = True
+            partner_form.is_group = False
+            partner_form.family_name = "Doe"
+            partner_form.given_name = "John"
+            partner_form.suffix_id = self.suffix_jr
+        individual = partner_form.save()
+        self.assertEqual(
+            individual.name,
+            "DOE, JOHN, JR.",
+            "Name should include suffix",
         )
-        self.assertEqual(individual.name, "DOE, JOHN, JR.", "Name should include suffix")
 
-    def test_04_name_without_suffix(self):
-        """Test that name is computed correctly without suffix."""
-        individual = self.env["res.partner"].create(
-            {
-                "family_name": "Doe",
-                "given_name": "Jane",
-                "is_registrant": True,
-                "is_group": False,
-            }
+    def test_04_name_without_suffix_using_form(self):
+        """Test that name is generated correctly without suffix."""
+        with Form(self.env["res.partner"]) as partner_form:
+            partner_form.is_registrant = True
+            partner_form.is_group = False
+            partner_form.family_name = "Doe"
+            partner_form.given_name = "Jane"
+        individual = partner_form.save()
+        self.assertEqual(
+            individual.name,
+            "DOE, JANE",
+            "Name should not have trailing comma when no suffix",
         )
-        self.assertEqual(individual.name, "DOE, JANE", "Name should not have trailing comma when no suffix")
 
-    def test_05_name_with_all_fields(self):
+    def test_05_name_with_all_fields_using_form(self):
         """Test name with all fields including addl_name and suffix."""
-        individual = self.env["res.partner"].create(
-            {
-                "family_name": "Smith",
-                "given_name": "Robert",
-                "addl_name": "James",
-                "suffix_id": self.suffix_phd.id,
-                "is_registrant": True,
-                "is_group": False,
-            }
+        with Form(self.env["res.partner"]) as partner_form:
+            partner_form.is_registrant = True
+            partner_form.is_group = False
+            partner_form.family_name = "Smith"
+            partner_form.given_name = "Robert"
+            partner_form.addl_name = "James"
+            partner_form.suffix_id = self.suffix_phd
+        individual = partner_form.save()
+        self.assertEqual(
+            individual.name,
+            "SMITH, ROBERT JAMES, PHD",
+            "Name should include all parts including suffix",
         )
-        self.assertEqual(individual.name, "SMITH, ROBERT, JAMES, PHD", "Name should include all parts including suffix")
 
     def test_06_group_name_unaffected(self):
         """Test that group name is not affected by suffix logic."""
@@ -110,10 +116,16 @@ def test_06_group_name_unaffected(self):
                 "is_group": True,
             }
         )
-        self.assertEqual(group.name, "Test Group", "Group name should not include suffix")
+        # Call name_change to simulate form behavior
+        group.name_change()
+        self.assertEqual(
+            group.name,
+            "Test Group",
+            "Group name should not include suffix",
+        )
 
-    def test_07_suffix_update_triggers_name_recompute(self):
-        """Test that updating suffix triggers name recomputation."""
+    def test_07_name_change_method_direct_call(self):
+        """Test name_change method called directly."""
         individual = self.env["res.partner"].create(
             {
                 "family_name": "Johnson",
@@ -122,10 +134,18 @@ def test_07_suffix_update_triggers_name_recompute(self):
                 "is_group": False,
             }
         )
+        # Call name_change to generate name
+        individual.name_change()
         self.assertEqual(individual.name, "JOHNSON, MICHAEL")
 
-        individual.write({"suffix_id": self.suffix_phd.id})
-        self.assertEqual(individual.name, "JOHNSON, MICHAEL, PHD", "Name should update when suffix is added")
+        # Add suffix and call name_change again
+        individual.suffix_id = self.suffix_phd.id
+        individual.name_change()
+        self.assertEqual(
+            individual.name,
+            "JOHNSON, MICHAEL, PHD",
+            "Name should update when suffix is added",
+        )
 
     def test_08_suffix_removal(self):
         """Test that removing suffix updates the name correctly."""
@@ -138,7 +158,13 @@ def test_08_suffix_removal(self):
                 "is_group": False,
             }
         )
+        individual.name_change()
         self.assertEqual(individual.name, "WILLIAMS, SARAH, JR.")
 
-        individual.write({"suffix_id": False})
-        self.assertEqual(individual.name, "WILLIAMS, SARAH", "Name should update when suffix is removed")
+        individual.suffix_id = False
+        individual.name_change()
+        self.assertEqual(
+            individual.name,
+            "WILLIAMS, SARAH",
+            "Name should update when suffix is removed",
+        )