Merge pull request #207 from OpenSourceOrg/fix/api-redirect-issues__dev

Move from name= to id= in url params

Author: gin0115

mu-plugins/osi-api/osi-api.php

@@ -49,17 +49,17 @@ public function register_routes() {
 				'callback'            => array( $this, 'get_licenses' ),
 				'permission_callback' => '__return_true',
 				'args'                => array(
-					'license_name' => array(
+					'id'      => array(
 						'required'    => false,
 						'type'        => 'string',
 						'description' => 'Filter by license name',
 					),
-					'keyword'      => array(
+					'keyword' => array(
 						'required'    => false,
 						'type'        => 'string',
 						'description' => 'Filter licenses by keyword',
 					),
-					'steward'      => array(
+					'steward' => array(
 						'required'    => false,
 						'type'        => 'string',
 						'description' => 'Filter licenses by steward',
@@ -111,7 +111,7 @@ public function register_routes() {
 	public function get_licenses( WP_REST_Request $data ) {
 
 		// Check if we have an ID passed.
-		$name = $data->get_param( 'license_name' );
+		$searched_slug = $data->get_param( 'id' );
 
 		// Check if we have any keyword passed.
 		$keyword = $data->get_param( 'keyword' );
@@ -127,11 +127,11 @@ public function get_licenses( WP_REST_Request $data ) {
 		);
 
 		// If we have an id, search for posts with a name LIKE
-		if ( ! empty( $name ) ) {
+		if ( ! empty( $searched_slug ) ) {
 			// Add the filter
 			add_filter( 'posts_where', array( $this, 'posts_where_title_like' ), 10, 2 );
 
-			$args['post_title_like'] = sanitize_text_field( $name ); // Use the post name (slug) to filter by ID
+			$args['post_title_like'] = sanitize_text_field( $searched_slug ); // Use the post name (slug) to filter by ID
 		} elseif ( ! empty( $keyword ) ) {
 			// Add a tax query on taxonomy-license-category where passed term is a the slug
 			$args['tax_query'] = array(
@@ -357,11 +357,6 @@ public function handle_redirects() {
 			// Add query parameters if any
 			if ( ! empty( $_GET ) ) { // phpcs:ignore WordPress.Security.NonceVerification
 				foreach ( $_GET as $key => $value ) { // phpcs:ignore WordPress.Security.NonceVerification
-					// Remap reserved "name" param to avoid canonical redirect
-					if ( 'name' === $key ) {
-						$key = 'license_name';
-					}
-
 					$sanitized_key   = sanitize_key( $key );
 					$sanitized_value = is_array( $value )
 						? array_map( 'sanitize_text_field', $value )