From 6b78218661e491a899decf3b0da2c56b3bfb6898 Mon Sep 17 00:00:00 2001
From: Stijn Beukers-Roozen <sbeukers@thepeoplegroup.nl>
Date: Wed, 2 Jul 2025 16:00:08 +0200
Subject: [PATCH 1/2] removed error handling from result handler

---
 sdk/src/lib/handlers/ResultHandler.ts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sdk/src/lib/handlers/ResultHandler.ts b/sdk/src/lib/handlers/ResultHandler.ts
index c1d358e..095e553 100644
--- a/sdk/src/lib/handlers/ResultHandler.ts
+++ b/sdk/src/lib/handlers/ResultHandler.ts
@@ -11,9 +11,6 @@ export class ResultHandler extends JobHandler {
     return messages$.pipe(
       map((message) => {
         const result = JobResult.deserializeBinary(message.content);
-        if (result.getResultType() === JobResult.ResultType.ERROR) {
-          throw new Error(`Job ${result.getUuid()} failed: ${result.getLogs()}`);
-        }
         return result.toObject();
       })
     );

From ea84b7c060cfc5e2439e762afccc38f86b3b23be Mon Sep 17 00:00:00 2001
From: Stijn Beukers-Roozen <sbeukers@thepeoplegroup.nl>
Date: Wed, 2 Jul 2025 16:14:15 +0200
Subject: [PATCH 2/2] fixed test to no longer require error to be thrown

---
 sdk/src/lib/handlers/ResultHandler.spec.ts | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/sdk/src/lib/handlers/ResultHandler.spec.ts b/sdk/src/lib/handlers/ResultHandler.spec.ts
index e840be3..7b2a0f0 100644
--- a/sdk/src/lib/handlers/ResultHandler.spec.ts
+++ b/sdk/src/lib/handlers/ResultHandler.spec.ts
@@ -44,12 +44,18 @@ describe('ResultsHandler', () => {
 
     it('should error when not succeeded', (done) => {
       handler.getResult().subscribe({
-        next: () => {
-          done.fail('Should not have succeeded');
+        next: (result) => {
+        expect(result).toEqual({
+          uuid: 'uuid',
+          logs: 'logs',
+          outputEsdl: '',
+          resultType: JobResult.ResultType.ERROR,
+          esdlMessagesList: [],
+        });
+          done()
         },
-        error: (error) => {
-          expect(error.message).toEqual('Job uuid failed: logs');
-          done();
+        error: () => {
+          done.fail('should not have thrown error')
         },
         complete: () => {
           done.fail('Should not have completed');