error: upgrade Version: 3.5.3 to 3.7.1

[SiberMedya]

Parse error: syntax error, unexpected token "endif" in \httpdocs\wp-admin\includes\upgrade.php on line 654
/wp-admin/upgrade.php
Version: 3.5.3 to 3.7.1

[SiberMedya]

projectnami371/wp-admin/install.php
Parse error: syntax error, unexpected token "endif" in \httpdocs\projectnami371\wp-admin\includes\upgrade.php on line 654

[danielsnc]

just delete { at the line 625 and 674 from /wp-admin/upgrade.php

[PHuhn]

Hey Patrick, Siber and Daniel:

I had the same issue that Siber had.

I use VS Code as an editor and it shows errors of unmatched braces {}. I found 2 different unmatched braces in upgrade.php. Listing starting at 619, I added a closing brace after the return on line 627;

function wp_upgrade() {
	global $wp_current_db_version, $wp_db_version;

	$wp_current_db_version = (int) __get_option( 'db_version' );

	// We are up to date. Nothing to do.
	if ( $wp_db_version === $wp_current_db_version ) {
		return;
	}

	if ( ! is_blog_installed() )
		return;

The second error is in the function directly following the function wp-upgrade. Listing starting at 669, I added a closing brace after the return on line 677;

function upgrade_all() {
	global $wp_current_db_version, $wp_db_version;

	$wp_current_db_version = (int) __get_option( 'db_version' );

	// We are up to date. Nothing to do.
	if ( $wp_db_version === $wp_current_db_version ) {
		return;
	}

	if ( empty($wp_current_db_version) )
		$wp_current_db_version = 0;

[PHuhn]

Hey Patrick:
I don't know if this is the correct solution for PHP Deprecated null error, but I changed function get_var in wp-includes\class-wpdb.php as follows:

	public function get_var( $query = null, $x = 0, $y = 0 ) {
		$this->func_call = "\$db->get_var(\"$query\", $x, $y)";

		...

		// If there is a value return it, else return null.
		return ( isset( $values[ $x ] ) && '' !== $values[ $x ] ) ? $values[ $x ] : '';
	}

I don't know if this is the correct solution for PHP Deprecated null error, but I changed function wp_version_check in wp-includes\update.php on line 211 as follows:

function wp_version_check( $extra_stats = array(), $force_check = false ) {
	global $wpdb, $wp_local_package;
       ...
	$pn_url = $pn_http_url = 'http://pnsrc.azurewebsites.net/sitedata/?' . http_build_query( $pn_query, '', '&' );
       ...
}

In both cases I replaced null with ''.

[patrickebates]

Are you seeing actual Errors or just Warnings?

[PHuhn]

Are you seeing actual Errors or just Warnings?

I applied it to an existing WordPress site, I got the following message in the admin app:

Deprecated: version_compare(): Passing null to parameter #1 ($version1) of type string is deprecated in C:\inetpub\WP_ColSq_2020_01\wp-includes\class-wpdb.php on line 4141

Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in C:\inetpub\WP_ColSq_2020_01\wp-includes\update.php on line 220

[PHuhn]

Hey Patrick:

Deprecated: version_compare(): Passing null to parameter #1 ($version1) of type string is deprecated in C:\inetpub\WP_ColSq_2020_01\wp-includes\class-wpdb.php on line 4141

In class-wpdb.php starting line 3052 changed line 3074 null to ''

	public function get_var( $query = null, $x = 0, $y = 0 ) {
		$this->func_call = "\$db->get_var(\"$query\", $x, $y)";

		if ( $query ) {
			if ( $this->check_current_query && $this->check_safe_collation( $query ) ) {
				$this->check_current_query = false;
			}

			$this->query( $query );
		}

		// Extract var out of cached results based on x,y vals.
		if ( !empty( $this->last_result[$y] ) ) {
			
			if( is_object( $this->last_result [$y]) )
				$values = array_values( get_object_vars( $this->last_result[$y] ) );
			else
				$values = array_values( $this->last_result[$y] );
		
		}

		// If there is a value return it, else return null.
		return ( isset( $values[ $x ] ) && '' !== $values[ $x ] ) ? $values[ $x ] : '';
	}

Deprecated: http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated in C:\inetpub\WP_ColSq_2020_01\wp-includes\update.php on line 220

In update.php on line 220 changed the 2nd parameter to http_build_query from null to ''

function wp_version_check( $extra_stats = array(), $force_check = false ) {
	global $wpdb, $wp_local_package;
	...
	$pn_url = $pn_http_url = 'http://pnsrc.azurewebsites.net/sitedata/?' . http_build_query( $pn_query, '', '&' );
	...