Skip to content

Remove dependency on cose for message signing #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cffls merged 2 commits into from
Jan 26, 2026
Merged

Remove dependency on cose for message signing #477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5074c4b
Remove dependency on cose for message signing
cffls Jan 26, 2026
98fac73
format
cffls Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions pycardano/cip/cip8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,20 +90,14 @@ def sign(

msg.key = cose_key # attach the key to the message

if isinstance(signing_key, ExtendedSigningKey):
_message = [
msg.phdr_encoded,
msg.uhdr_encoded,
msg.payload,
signing_key.sign(msg._sig_structure),
]

encoded = dumps(
CBORTag(msg.cbor_tag, _message), default=msg._custom_cbor_encoder
)

else:
encoded = msg.encode()
_message = [
msg.phdr_encoded,
msg.uhdr_encoded,
msg.payload,
signing_key.sign(msg._sig_structure),
]

encoded = dumps(CBORTag(msg.cbor_tag, _message), default=msg._custom_cbor_encoder)

# turn the enocded message into a hex string and remove the first byte
# which is always "d2"
Expand Down