HomeworkWeek11 Briac Ledermann #3
Description
In my opinion the code is written in a very concise way and its very readable. But over all i dont have many comments about the code. Because of that my suggestions are gonna focus on functions mainly and are highly subjectiv.
Rating: I feel like there need to be more restraints as i can currently rate a book 10000 or something like that and i think it would make sense to restrict this one of the normal rating scales (1/10 or 1/5 maybe even 1/100) especially because there is already a validator implemented.
Search: I think its a bit counterintuitiv that i can only search books by author title or genre as it can be equally in my intrest to search for books that i gave a high rating or a book that came out in a certain year. It would atleast be nice to have an indicator that the search only work on some critiria.
Add: I like the simplified mask alot and also like that it gets filled with the values when i click on a book in my storage i dont know if it would be benficial to only be able to add one copy of a book or maybe have an additional variable as a book count to store multiple books in one entry. But this is again highly subjectiv.
Delete: i dont know if its a problem on my side but for me the delete button didnt work. I looked at the code but couldnt figure out what was causing that because it seems that the delete method from the manager class is never called. We are facing a similar issue in our own project.
Genres: I would prefer to have maybe a list to choose from where i could also add new ones.
Comments: Even tough there are not alot of comments i never felt lost and the comments are well placed while the rest is selfexplanitory
I liked the minimalistic approach aswell as the clean code as i never had any trouble following it. Overall i would consider to use the programm to organise my own library.
Briac Ledermann