Skip to content

Commit 6adcc64

Browse files
committed
Merge pull request #56 from neilpa/rac4-alpha3
Update RAC to 4.0-alpha.3
2 parents 71263b2 + 268e4f2 commit 6adcc64

File tree

10 files changed

+17
-18
lines changed

10 files changed

+17
-18
lines changed

Cartfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
github "ReactiveCocoa/ReactiveCocoa" "v4.0.0-alpha.2"
1+
github "ReactiveCocoa/ReactiveCocoa" "v4.0.0-alpha.3"

Cartfile.resolved

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
github "antitypical/Result" "0.6.0-beta.3"
2-
github "ReactiveCocoa/ReactiveCocoa" "v4.0.0-alpha.2"
1+
github "antitypical/Result" "0.6.0-beta.5"
2+
github "ReactiveCocoa/ReactiveCocoa" "v4.0.0-alpha.3"

Source/AppKit/NSTextField.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import ReactiveCocoa
1111
import AppKit
1212

1313
extension NSTextField {
14-
/// only changes from UI will be produced here
14+
/// Sends the field's string value whenever it changes.
1515
public var rex_textSignal: SignalProducer<String, NoError> {
1616
return NSNotificationCenter.defaultCenter()
1717
.rac_notifications(NSControlTextDidChangeNotification, object: self)

Source/Foundation/Association.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ public func associatedObject<T: AnyObject>(host: AnyObject, key: UnsafePointer<(
7474
if value == nil {
7575
value = initial()
7676
objc_setAssociatedObject(host, key, value, .OBJC_ASSOCIATION_RETAIN)
77-
// objc_setAssociatedObject(host, key, value, objc_AssociationPolicy())
7877
}
7978
return value!
8079
}

Source/Foundation/NSData.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ extension NSData {
1919
observer.sendNext(data)
2020
observer.sendCompleted()
2121
} catch {
22-
observer.sendError(error as NSError)
22+
observer.sendFailed(error as NSError)
2323
}
2424
}
2525
}

Source/Signal.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ extension SignalType {
1818
if let val = transform(value) {
1919
observer.sendNext(val)
2020
}
21-
}, error: { error in
22-
observer.sendError(error)
21+
}, failed: { error in
22+
observer.sendFailed(error)
2323
}, completed: {
2424
observer.sendCompleted()
2525
}, interrupted: {
@@ -38,7 +38,7 @@ extension SignalType {
3838
switch event {
3939
case let .Next(value):
4040
observer.sendNext(value)
41-
case .Error:
41+
case .Failed:
4242
observer.action(replacement)
4343
case .Completed:
4444
observer.sendCompleted()
@@ -80,8 +80,8 @@ extension SignalType where Value: SequenceType {
8080
switch event {
8181
case let .Next(sequence):
8282
sequence.forEach { observer.sendNext($0) }
83-
case let .Error(error):
84-
observer.sendError(error)
83+
case let .Failed(error):
84+
observer.sendFailed(error)
8585
case .Completed:
8686
observer.sendCompleted()
8787
case .Interrupted:

Source/SignalProducer.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ extension SignalProducerType {
3636

3737
group!.sendNext(value)
3838

39-
}, error: { error in
40-
observer.sendError(error)
41-
groups.values.forEach { $0.sendError(error) }
39+
}, failed: { error in
40+
observer.sendFailed(error)
41+
groups.values.forEach { $0.sendFailed(error) }
4242

4343
}, completed: { _ in
4444
observer.sendCompleted()

Tests/SignalTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ final class SignalTests: XCTestCase {
4848
sink.sendNext(1)
4949
XCTAssertFalse(completed)
5050

51-
sink.sendError(.Default)
51+
sink.sendFailed(.Default)
5252
XCTAssertTrue(completed)
5353
}
5454

@@ -65,7 +65,7 @@ final class SignalTests: XCTestCase {
6565
sink.sendNext(1)
6666
XCTAssertFalse(interrupted)
6767

68-
sink.sendError(.Default)
68+
sink.sendFailed(.Default)
6969
XCTAssertTrue(interrupted)
7070
}
7171

0 commit comments

Comments
 (0)