Skip to content

rocm-cmake enable Lintian Support #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonatluu wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

rocm-cmake enable Lintian Support #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3a55f1b
fix lintian errors for rocm-libraries: no changelog, no copyright, di…
jonatluu Oct 9, 2025
7755297
wip parse email and name from maintainer. move lintian overrides into…
jonatluu Oct 14, 2025
1042bb3
update rocm-cmake lintian
jonatluu Oct 16, 2025
818c09a
remove unneeded code
jonatluu Oct 16, 2025
aba5a3b
add lintian overrides to rocm-cmake
jonatluu Oct 20, 2025
fee2204
move DEBIAN folder to /opt/rocm-7.1.0/share/rocmcmakebuildtools/cmake…
jonatluu Oct 21, 2025
832dac0
use flag CPACK_GENERATOR to determine pkg type
jonatluu Oct 22, 2025
550f65e
don't apply lintian overrides to rocm-cmake
jonatluu Oct 27, 2025
1193334
fix formatting
jonatluu Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions share/rocmcmakebuildtools/cmake/DEBIAN/changelog.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
@DEB_PACKAGE_NAME@ (@DEB_PACKAGE_VERSION@) stable; urgency=low

* ROCm Runtime software stack Base Package.
-- @DEB_MAINTAINER_NAME@ <@DEB_MAINTAINER_EMAIL@> @DEB_TIMESTAMP@

25 changes: 25 additions & 0 deletions share/rocmcmakebuildtools/cmake/DEBIAN/copyright.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: @DEB_PACKAGE_NAME@
Upstream-Contact: @DEB_MAINTAINER_NAME@ <@DEB_MAINTAINER_EMAIL@>
Source: https://github.com/ROCm/@DEB_PACKAGE_NAME@
Files: *
License: @DEB_LICENSE@
Copyright: @DEB_COPYRIGHT_YEAR@ Advanced Micro Devices, Inc. All rights Reserved.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
3 changes: 3 additions & 0 deletions share/rocmcmakebuildtools/cmake/DEBIAN/overrides.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
@DEB_OVERRIDES_INSTALL_FILENM@: no-copyright-file
@DEB_OVERRIDES_INSTALL_FILENM@: debian-changelog-file-missing
@DEB_OVERRIDES_INSTALL_FILENM@: dir-or-file-in-opt
25 changes: 25 additions & 0 deletions share/rocmcmakebuildtools/cmake/ROCMCreatePackage.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,19 @@ macro(rocm_create_package)
set(CPACK_NSIS_MODIFY_PATH On)
set(CPACK_NSIS_PACKAGE_NAME ${PARSE_NAME})

if(NOT( ${CPACK_PACKAGE_NAME} STREQUAL "rocm-cmake"))
# parse MAINTAINER format: PKG_MAINTAINER_NM <PKG_MAINTAINER_EMAIL>"
# parse text before first '<'
string(REGEX MATCH "^(.*)\<" _ "${CPACK_DEBIAN_PACKAGE_MAINTAINER}")
set(MAINTAINER_NM "${CMAKE_MATCH_1}")
# parse text between '<...>'
string(REGEX MATCH "<([^>]+)>" _ "${CPACK_DEBIAN_PACKAGE_MAINTAINER}")
set(MAINTAINER_EMAIL "${CMAKE_MATCH_1}")
endif()

set(LINTIAN_OVERRIDES_FLAG ON CACHE BOOL "Enable/Disable Lintian Overrides")
set(DEBIAN_PKGING_FLAG ON CACHE BOOL "Internal Status Flag to indicate Debian Packaging Build" )

set(CPACK_RPM_PACKAGE_RELOCATABLE Off)
set(CPACK_RPM_PACKAGE_AUTOREQPROV
Off
Expand Down Expand Up @@ -482,17 +495,29 @@ macro(rocm_setup_license HEADER_ONLY)
FILES ${CPACK_RESOURCE_FILE_LICENSE}
DESTINATION share/doc/${_rocm_cpack_package_name}-asan
)
set( COMP_TYPE "asan" )
if(NOT( ${CPACK_PACKAGE_NAME} STREQUAL "rocm-cmake"))
configure_pkg( ${CPACK_PACKAGE_NAME} ${COMP_TYPE} ${CPACK_PACKAGE_VERSION} ${MAINTAINER_NM} ${MAINTAINER_EMAIL} ${CPACK_GENERATOR})
endif()
elseif((ROCM_USE_DEV_COMPONENT AND ${HEADER_ONLY}) OR NOT BUILD_SHARED_LIBS)
install(
FILES ${CPACK_RESOURCE_FILE_LICENSE}
DESTINATION share/doc/${_rocm_cpack_package_name}
COMPONENT devel
)
set( COMP_TYPE "devel" )
if(NOT( ${CPACK_PACKAGE_NAME} STREQUAL "rocm-cmake"))
configure_pkg( ${CPACK_PACKAGE_NAME} ${COMP_TYPE} ${CPACK_PACKAGE_VERSION} ${MAINTAINER_NM} ${MAINTAINER_EMAIL} ${CPACK_GENERATOR})
endif()
else()
install(
FILES ${CPACK_RESOURCE_FILE_LICENSE}
DESTINATION share/doc/${_rocm_cpack_package_name}
)
set( COMP_TYPE "runtime" )
if(NOT( ${CPACK_PACKAGE_NAME} STREQUAL "rocm-cmake"))
configure_pkg( ${CPACK_PACKAGE_NAME} ${COMP_TYPE} ${CPACK_PACKAGE_VERSION} ${MAINTAINER_NM} ${MAINTAINER_EMAIL} ${CPACK_GENERATOR})
endif()
endif()
endif()
endmacro()
Expand Down
124 changes: 124 additions & 0 deletions share/rocmcmakebuildtools/cmake/ROCMInstallTargets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,3 +454,127 @@ function(rocm_export_targets)
rocm_install(SCRIPT "${CMAKE_CURRENT_BINARY_DIR}/cmake_symlink.cmake")
endif()
endfunction()

## Configure Copyright File for Debian Package
function( configure_pkg PACKAGE_NAME_T COMPONENT_NAME_T PACKAGE_VERSION_T MAINTAINER_NM_T MAINTAINER_EMAIL_T PACKAGE_TYPE_T)
# Check If Debian Platform
if(PACKAGE_TYPE_T STREQUAL "DEB")
set( DEBIAN_PKGING_FLAG ON CACHE BOOL "Internal Status Flag to indicate Debian Packaging Build" FORCE )
set_debian_pkg_cmake_flags( ${PACKAGE_NAME_T} ${PACKAGE_VERSION_T}
${MAINTAINER_NM_T} ${MAINTAINER_EMAIL_T} )

# Create debian directory in build tree
file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/DEBIAN")

# Configure the copyright file
configure_file(
"${CMAKE_CURRENT_FUNCTION_LIST_DIR}/DEBIAN/copyright.in"
"${CMAKE_BINARY_DIR}/DEBIAN/copyright"
@ONLY
)

# Install copyright file
install ( FILES "${CMAKE_BINARY_DIR}/DEBIAN/copyright"
DESTINATION "${CMAKE_INSTALL_DOCDIR}"
COMPONENT ${COMPONENT_NAME_T} )

# Configure the changelog file
configure_file(
"${CMAKE_CURRENT_FUNCTION_LIST_DIR}/DEBIAN/changelog.in"
"${CMAKE_BINARY_DIR}/DEBIAN/changelog.Debian"
@ONLY
)

if( LINTIAN_OVERRIDES_FLAG )
if(NOT BUILD_SHARED_LIBS)
string(FIND ${DEB_OVERRIDES_INSTALL_FILENM} "static" OUT_VAR1)
if(OUT_VAR1 EQUAL -1)
set( DEB_OVERRIDES_INSTALL_FILENM "${DEB_OVERRIDES_INSTALL_FILENM}-static" )
endif()
else()
if(ENABLE_ASAN_PACKAGING)
string( FIND ${DEB_OVERRIDES_INSTALL_FILENM} "asan" OUT_VAR2)
if(OUT_VAR2 EQUAL -1)
set( DEB_OVERRIDES_INSTALL_FILENM "${DEB_OVERRIDES_INSTALL_FILENM}-asan" )
endif()
endif()
endif()
set( DEB_OVERRIDES_INSTALL_FILENM
"${DEB_OVERRIDES_INSTALL_FILENM}" CACHE STRING "Debian Package Lintian Override File Name" FORCE)
# Configure the changelog file
configure_file(
"${CMAKE_CURRENT_FUNCTION_LIST_DIR}/DEBIAN/overrides.in"
"${CMAKE_BINARY_DIR}/DEBIAN/${DEB_OVERRIDES_INSTALL_FILENM}"
FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
@ONLY
)
endif()

# Install Change Log
find_program ( DEB_GZIP_EXEC gzip )
if(EXISTS "${CMAKE_BINARY_DIR}/DEBIAN/changelog.Debian" )
execute_process(
COMMAND ${DEB_GZIP_EXEC} -f -n -9 "${CMAKE_BINARY_DIR}/DEBIAN/changelog.Debian"
WORKING_DIRECTORY "${CMAKE_BINARY_DIR}/DEBIAN"
RESULT_VARIABLE result
OUTPUT_VARIABLE output
ERROR_VARIABLE error
)
if(NOT ${result} EQUAL 0)
message(FATAL_ERROR "Failed to compress: ${error}")
endif()
install ( FILES "${CMAKE_BINARY_DIR}/DEBIAN/${DEB_CHANGELOG_INSTALL_FILENM}"
DESTINATION ${CMAKE_INSTALL_DOCDIR}
COMPONENT ${COMPONENT_NAME_T})
endif()

if( LINTIAN_OVERRIDES_FLAG STREQUAL "ON" AND DEBIAN_PKGING_FLAG STREQUAL "ON")
set( OVERRIDE_FILE "${CMAKE_BINARY_DIR}/DEBIAN/${DEB_OVERRIDES_INSTALL_FILENM}" )
install ( FILES ${OVERRIDE_FILE}
DESTINATION ${DEB_OVERRIDES_INSTALL_PATH}
COMPONENT ${COMPONENT_NAME_T})
endif()

else()
# License file
install ( FILES ${LICENSE_FILE}
DESTINATION ${CMAKE_INSTALL_DOCDIR} RENAME LICENSE.txt
COMPONENT ${COMPONENT_NAME_T})
endif()
endfunction()

# Set variables for changelog and copyright
# For Debian specific Packages
function( set_debian_pkg_cmake_flags DEB_PACKAGE_NAME_T DEB_PACKAGE_VERSION_T DEB_MAINTAINER_NM_T DEB_MAINTAINER_EMAIL_T )
# Setting configure flags
set( DEB_PACKAGE_NAME "${DEB_PACKAGE_NAME_T}" CACHE STRING "Debian Package Name" )
set( DEB_PACKAGE_VERSION "${DEB_PACKAGE_VERSION_T}" CACHE STRING "Debian Package Version String" )
set( DEB_MAINTAINER_NAME "${DEB_MAINTAINER_NM_T}" CACHE STRING "Debian Package Maintainer Name" )
set( DEB_MAINTAINER_EMAIL "${DEB_MAINTAINER_EMAIL_T}" CACHE STRING "Debian Package Maintainer Email" )
set( DEB_COPYRIGHT_YEAR "2025" CACHE STRING "Debian Package Copyright Year" )
set( DEB_LICENSE "MIT" CACHE STRING "Debian Package License Type" )
set( DEB_CHANGELOG_INSTALL_FILENM "changelog.Debian.gz" CACHE STRING "Debian Package ChangeLog File Name" )

if( LINTIAN_OVERRIDES_FLAG )
set( DEB_OVERRIDES_INSTALL_FILENM "${DEB_PACKAGE_NAME}" CACHE STRING "Debian Package Lintian Override File Name" )
set( DEB_OVERRIDES_INSTALL_PATH "/usr/share/lintian/overrides/" CACHE STRING "Deb Pkg Lintian Override Install Loc" )
endif()

# Get TimeStamp
find_program( DEB_DATE_TIMESTAMP_EXEC date )
set ( DEB_TIMESTAMP_FORMAT_OPTION "-R" )
execute_process (
COMMAND ${DEB_DATE_TIMESTAMP_EXEC} ${DEB_TIMESTAMP_FORMAT_OPTION}
OUTPUT_VARIABLE TIMESTAMP_T
)
set( DEB_TIMESTAMP "${TIMESTAMP_T}" CACHE STRING "Current Time Stamp for Copyright/Changelog" )

message(STATUS "DEB_PACKAGE_NAME : ${DEB_PACKAGE_NAME}" )
message(STATUS "DEB_PACKAGE_VERSION : ${DEB_PACKAGE_VERSION}" )
message(STATUS "DEB_MAINTAINER_NAME : ${DEB_MAINTAINER_NAME}" )
message(STATUS "DEB_MAINTAINER_EMAIL : ${DEB_MAINTAINER_EMAIL}" )
message(STATUS "DEB_COPYRIGHT_YEAR : ${DEB_COPYRIGHT_YEAR}" )
message(STATUS "DEB_LICENSE : ${DEB_LICENSE}" )
message(STATUS "DEB_TIMESTAMP : ${DEB_TIMESTAMP}" )
message(STATUS "DEB_CHANGELOG_INSTALL_FILENM : ${DEB_CHANGELOG_INSTALL_FILENM}" )
endfunction()
Loading