From 0f1780c8ea04df762341bfd1554607478fd14cf0 Mon Sep 17 00:00:00 2001 From: Ruturaj4 Date: Fri, 20 Feb 2026 16:28:58 -0600 Subject: [PATCH] add xxd dependency in the manylinux docker images --- docker/manylinux/Dockerfile.jax-manylinux_2_28-rocm | 2 +- docker/manylinux/Dockerfile.jax-manylinux_2_28-therock | 2 +- .../rocm/build_wheels/Dockerfile.manylinux_2_28_x86_64.rocm | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/docker/manylinux/Dockerfile.jax-manylinux_2_28-rocm b/docker/manylinux/Dockerfile.jax-manylinux_2_28-rocm index 6d9018b123..a1ba7f71e0 100644 --- a/docker/manylinux/Dockerfile.jax-manylinux_2_28-rocm +++ b/docker/manylinux/Dockerfile.jax-manylinux_2_28-rocm @@ -7,7 +7,7 @@ ENV GPU_DEVICE_TARGETS="gfx906 gfx908 gfx90a gfx942 gfx950 gfx1030 gfx1100 gfx11 # Install patchelf and headers for numactl RUN --mount=type=cache,target=/var/cache/dnf \ - dnf install -y patchelf numactl-devel + dnf install -y patchelf numactl-devel vim-common # Install ROCm RUN --mount=type=cache,target=/var/cache/dnf \ diff --git a/docker/manylinux/Dockerfile.jax-manylinux_2_28-therock b/docker/manylinux/Dockerfile.jax-manylinux_2_28-therock index e3feee45d7..6a3b5f2032 100644 --- a/docker/manylinux/Dockerfile.jax-manylinux_2_28-therock +++ b/docker/manylinux/Dockerfile.jax-manylinux_2_28-therock @@ -7,7 +7,7 @@ ENV GPU_DEVICE_TARGETS="gfx906 gfx908 gfx90a gfx942 gfx950 gfx1030 gfx1100 gfx11 # Install patchelf and headers for numactl RUN --mount=type=cache,target=/var/cache/dnf \ - dnf install -y patchelf numactl-devel + dnf install -y patchelf numactl-devel vim-common # Install ROCm RUN --mount=type=cache,target=/var/cache/dnf \ diff --git a/jax_rocm_plugin/build/rocm/build_wheels/Dockerfile.manylinux_2_28_x86_64.rocm b/jax_rocm_plugin/build/rocm/build_wheels/Dockerfile.manylinux_2_28_x86_64.rocm index 9187c4258e..f0d6a3a241 100644 --- a/jax_rocm_plugin/build/rocm/build_wheels/Dockerfile.manylinux_2_28_x86_64.rocm +++ b/jax_rocm_plugin/build/rocm/build_wheels/Dockerfile.manylinux_2_28_x86_64.rocm @@ -5,10 +5,6 @@ ARG ROCM_BUILD_JOB ARG ROCM_BUILD_NUM ARG THEROCK_PATH -# Install system GCC and C++ libraries, and build deps -RUN --mount=type=cache,target=/var/cache/dnf \ - dnf install -y patchelf numactl-devel - RUN --mount=type=cache,target=/var/cache/dnf \ --mount=type=bind,source=build/rocm/tools/get_rocm.py,target=get_rocm.py \ --mount=type=bind,from=therock,target=/tmp/therock/ \ @@ -20,7 +16,7 @@ RUN printf '%s\n' > /opt/rocm/bin/target.lst ${GPU_DEVICE_TARGETS} # Install LLVM 18 and dependencies. RUN --mount=type=cache,target=/var/cache/dnf \ - dnf install -y patchelf numactl-devel python3.11 python3.11-devel python3.11-pip wget && \ + dnf install -y patchelf numactl-devel vim-common python3.11 python3.11-devel python3.11-pip wget && \ rm -f /usr/bin/python3 && ln -sf /usr/bin/python3.11 /usr/bin/python3 && \ rm -f /usr/bin/pip3 && ln -sf /usr/bin/pip3.11 /usr/bin/pip3 && \ python3.11 -m pip install --upgrade pip setuptools wheel