Object not totalling correctly and are missing data types

[christianallred]

When updating my Overlay i noticed that a couple of items in the Encounter object are not getting totals sent up properly. Also the Encounter object is missing some of the new fields.

Totals Not coming through to Encounter properly:
crithit%: is returning 0% in all cases - Combatant object is returning values
critheals: I am not sure what this value is returning but it is not the number crit heals. it seems to be ticking up as i am auto-attacking so maybe it is getting its data from hits? not sure. But i ahve 29 heals, and 210 critheals atm.

missing items from Encounter:
crittypes: I personally don't care about having this, but just letting you know its not there.
DirectHitPct: Missing
CritDirectHitPct: Missing
OverHealPct: Missing, I don't really mind that it is missing.

Combatant Wrong Numbers:
critheals: returning 0's
critheal%: returning 0% - probably related to the above.

[christianallred]

I am sure there are more. this is just what i have found.

[hibiyasleep]

OverlayPlugin just reads data directly from ACT (yes it's EncounterDict, not CombatantDict), so this looks like bug of FFXIV_ACT_Plugin which supplies data or ACT itself, not OverlayPlugin.

[christianallred]

Ah, ok is the FFXIV plugin managed in github? I will submit my bugs there

[hibiyasleep]

Repository is here, however source isn't opened.