From a819b16139999ff21cd0e5e357d8ca2bac8373c3 Mon Sep 17 00:00:00 2001 From: Henrique Cezar Godoy Bueno Date: Wed, 27 Mar 2019 00:57:18 -0300 Subject: [PATCH 1/2] Added a check to only fire the metadata update event if the value actually changed --- src/Metadatable.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Metadatable.js b/src/Metadatable.js index a4878b99..e4e2e290 100644 --- a/src/Metadatable.js +++ b/src/Metadatable.js @@ -43,6 +43,10 @@ class extends parentClass { const oldValue = base[property]; base[property] = value; + if(oldValue === value) { + return; + } + /** * @event Metadatable#metadataUpdate * @param {string} key From 75882a8270644988035656189af9bb6d79176d81 Mon Sep 17 00:00:00 2001 From: Henrique Cezar Godoy Bueno Date: Thu, 28 Mar 2019 02:40:13 -0300 Subject: [PATCH 2/2] Flip them around. It was bothering me. --- src/Metadatable.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Metadatable.js b/src/Metadatable.js index e4e2e290..5fc5f4ff 100644 --- a/src/Metadatable.js +++ b/src/Metadatable.js @@ -43,7 +43,7 @@ class extends parentClass { const oldValue = base[property]; base[property] = value; - if(oldValue === value) { + if(value === oldValue) { return; }