Assertion failure for incorrect SGML

[nyamatongwe]

For this SGML, the '{' is not allowed and terminates SCE_H_SGML_COMMAND but the command is empty which fails inside isWordHSGML.

<!{2}>

Potential fix:

+++ b/lexers/LexHTML.cxx
@@ -453,6 +453,8 @@ void classifyWordHTPHP(Sci_PositionU start, Sci_PositionU end, const WordList &k
 }
 
 bool isWordHSGML(Sci_PositionU start, Sci_PositionU end, const WordList &keywords, const Accessor &styler) {
+	if (end < start)
+		return false;
 	const std::string s = styler.GetRange(start, end + 1);
 	return keywords.InList(s);
 }

[zufuliu]

Looks void LexAccessor::GetRange() and std::string LexAccessor::GetRange() have different assertions for the same range [startPos_, endPos_).

lexilla/lexlib/LexAccessor.cxx

Lines 33 to 35 in 3bdd5db

	void LexAccessor::GetRange(Sci_PositionU startPos_, Sci_PositionU endPos_, char *s, Sci_PositionU len) const {
	assert(s);
	assert(startPos_ <= endPos_ && len != 0);

lexilla/lexlib/LexAccessor.cxx

Lines 59 to 60 in 3bdd5db

	std::string LexAccessor::GetRange(Sci_PositionU startPos_, Sci_PositionU endPos_) const {
	assert(startPos_ < endPos_);