Spaces in video name are replaced with underscores

[redthirten]

Describe the bug
I could be misremembering, but I thought the previous behavior of Fireshare was to set the default name of uploaded videos to the same name as the original video file. However, I noticed recently that spaces are being replaced with underscores for the default video name. I wouldn't call this a bug per say, but from a cosmetic perspective, I'd prefer to throw a pre-named video up onto Fireshare and have the title metadata already set to the "pretty" name with spaces. Now, I need to take an extra step to rename the video before sharing, which is a little cumbersome. I understand certain characters may need to be stripped or changed to avoid certain injection attacks, but I'm uncertain if spaces fall into this category. Please correct me if this is not the case. Thank you!

To Reproduce
Steps to reproduce the behavior:

1. Upload a video file with spaces in the name.
2. Observe that the default video name in Fireshare is the original file name with underscores replacing spaces.
3. Renaming the video in Fireshare to have spaces still works.

Expected behavior
Ideally, the default video name in Fireshare should match the name of the original video file as closely as possible, while avoiding obvious injection attacks.

Desktop (please complete the following information):

• Browser: Chrome

[ShaneIsrael]

@redthirten yes all special characters are being removed as a blanket process to guarantee no injection attacks. Spaces could probably be allowed, I'll look into it.

[redthirten]

I tried looking into a fix myself just now, but quickly realized you are using a third-party library to secure the filename.

I found this StackOverflow thread to be insightful: https://stackoverflow.com/questions/7406102/create-sane-safe-filename-from-any-unsafe-string

The second reply gives an interesting explanation and likely the fastest solution. However, the first reply, while being slightly slower, is likely the cleanest / most readable solution.

I have not yet checked if a different third-party library could be used, but this might just be a case of "keep it simple stupid", haha.