[Features/bugs] Folder editing, sorting, advanced tagging for certain games, invites, etc

[mavproductions]

Hi there!
Things I'm noticing:

• Better folder renaming logic
  • I change a folder name to just have capitalized letters, and then all thumbnails go red, but still play
  • Or the old folder still shows up in menu and playable, while the new folder appears and is playable too (image below -- csgo --> counter strike global offensive ---- counter-strike 2 --> Counter-Strike 2)

• Tagging of clips as mentioned in Issue-364(2kills? 5kills? clutch (1v2/1v3/1v4/1v5?) is it a friend (friend tagging?)
  • Depending how invested into stats you are, checking out replay management/playback apps like CS Demo Manager could be a great way to break out into more feature-rich options for your users.

- Sorting by date created or something would be good as all my clips I need to name as original names to have "date created" style sorting which is a pain when I rather have advanced tagging/naming, and regular sort options whoops appears to already be implemented :P

• OIDC support for apps like PocketID/Authentik/etc would be AMAZING
• Perhaps working with wizarr could be cool for inviting friends, and then introducing an "uploaded by" field with that to go with tagging.
• Right now, the only way I can think of for separating my friend's videos from mine - in the same game - is to make folders like "counter-strike 2 - user1" + "counter-strike 2 - user2"
• Being able to click outside of the video player to exit the currently playing clip would be nice.
• Also being able to have autoplay + shuffle on would be cool as I would like to just watch my clips indefinitely on shuffle at times without having to click the shuffle button, and let alone have to make sure autoplay is going and enabled for my users.
• I think "Start Manual scan for games" could be better documented, as if a user has their folders setup properly for your app, it shouldn't be required much - if at all - I don't think?
• I have a game clip in my library "Shootmania Storm" and it doesn't have hero images and the like available for it apparently. It would be nice to be able to manually tie images to it.

Probably more but this is what I have off the top of my head at the moment. Love this app as-is too! Thanks for making this! ♥♥

[mavproductions]

I also noticed the shuffle logic needs some work. I have 110 or so clips and it's often that the same clips can reappear in shuffle between 1-4 shuffles.

[mavproductions]

having an env var for STEAMGRIDDB_API would be nice if I have to delete my metadata folders and start from scratch when I run into issues like "I change a folder name to just have capitalized letters, and then all thumbnails go red, but still play".

I know I can keep the config.json but I like to delete whole folders :>

[ShaneIsrael]

1. You can not change the source paths after videos have been scanned into fireshare. If you change the paths, it's going to assume the file is missing even if technically its still able to access the file. So renaming your folders after the fact is going to cause problems. This is by design so that if folders or drives are not found, nothing is done as it assume they will eventually be there again. |

2. Tagging is definitely something that can be improved and probably will be slowly over time.

3. OIDC, definitely not against it but its not something I'm going to invest into myself adding. Of course I welcome anybody who wants to try adding the support themselves.

4. Wizarr.. Sorry but no, there are no plans to have any heavy integrations that are not open standards. There's no guarantee Wizarr will be around 2 or 3 years from now and I can't guarantee that a Wizarr integration would always "just work". Wizarr is also meant to work with the Plex/Sonarr/Radarr stack. My philosophy is to keep Fireshare as simple and easy to use as possible which means being very selected with integrations. On top of that, I have no plans on adding a user system outside of the admin user. As its not meant to be a "YouTube" lite, it's meant to easily share your videos with links. If you want a user system, I recommend looking into Peertube.

5. Clicking outside a currently playing video to exit is a good suggestion.

6. Autoplay + shuffle. Potentially, probably not something I'll implement but if somebody wants to depending on how its implemented I may consider it.

7. Manual Scan for Games is a very new feature with the recent additions to the game categorization. The system will be improved over time, and ideally it should only be something you need to run once if you already have a large set of videos in your system.

8. Manual addition of game assets is not a bad idea, but it is a time consuming feature to add. A good idea, but no eta on something like that at the moment.

9. Shuffle logic. Not really sure whats up with that, but definitely needs to be looked into as I agree it shouldn't work the way it currently is. Something might have broke it in one of the many recent updates.

10. Env variable for STEAMGRIDDB_API is definitely needed I agree.

[mavproductions]

You can not change the source paths after videos have been scanned into fireshare. If you change the paths, it's going to assume the file is missing even if technically its still able to access the file. So renaming your folders after the fact is going to cause problems. This is by design so that if folders or drives are not found, nothing is done as it assume they will eventually be there again. |

Perhaps a refresh/optimize/clean database button - then?

If the tiniest error is made such as the wrong file extension makes it's way into the videos dir and is scanned - then added to the library or if you change the case of the letter to capitalizing, I have to reset view counts for already working videos. Maneuvering through manual deletion seems like it could cause a lot of user's I invite to my instance headaches as it's very unpredictable behavior IMO.

In this menu for example, I could see how some users would want either capitalized or non-capitalized, but if they change the folder's cases at all, it breaks the system which does not seem simple in it's current state.

My thought is that if I want to ever refresh my DB, I need to make sure the naming is correct of the video file, else if I renamed a lot of videos in fireshare, depending on how I refresh, all those names will be wiped, where as if I just rename the video file itself, it's persistent across instances.

or

if a user does a public upload, doesn't this mean I need to move them around to other folders to keep it all clean if I want to organize by games, let alone organize by players?

[ShaneIsrael]

There's probably a world in which this could definitely be done better and be a lot more user friendly. I think to do it properly a bit of a rework would be needed. Possibly a configuration page where you can rename your folders within Fireshare without actually changing the folder or paths on the system.

And yes the the upload stuff needs a lot of work. It was added quickly in a very simple manner and honestly is one of the pieces I want to rework the most.

[dammitjeff]

I think "Start Manual scan for games" could be better documented, as if a user has their folders setup properly for your app, it shouldn't be required much - if at all - I don't think?

This is how it's currently set up, yes. If your folders are properly organized, that button will scan the names of your folders and will mass tag all video clips inside of it.

As of now, nothing will automatically tag/sort itself without explicit approval from the user. My contributions set it up this way intentionally. As trying to automate sorting without a proper look by a human has the potential to mess up a database of videos VERY badly, which I didn't want!

[mavproductions]

Any updates on this? Specifically the volatility of a user's library if any changes to file names etc for the sake of setting up a new instance but bringing over the same data, or manipulating file/folder structure without destroying the DB(view counts etc)?

[ShaneIsrael]

Not at the moment. I do not have any plans on updating Fireshare to automatically make database changes based on changes in the mounted library. If you need to move something out of the library or to a new location, for now, you will need to first move said video and then delete the "file missing" version via the Fireshare UI.

That's not to say it won't ever get added. I have some ideas on how to have it automatically update itself if a files name is simply changed or moved, but there is no ETA on adding that.

In terms of deleting files though, that must be done through the UI. If you delete a file out of your library, Fireshare will not delete it's database entry until the user has specifically told it to from the UI as a safety feature. If a drive doesn't mount correctly or someone accidentally moves a folder, that's no different than a file being deleted. So I can't have fireshare automatically remove entries from it's database unless a user tells it to.

[mavproductions]

Not at the moment. I do not have any plans on updating Fireshare to automatically make database changes based on changes in the mounted library. If you need to move something out of the library or to a new location, for now, you will need to first move said video and then delete the "file missing" version via the Fireshare UI.

That's not to say it won't ever get added. I have some ideas on how to have it automatically update itself if a files name is simply changed or moved, but there is no ETA on adding that.

In terms of deleting files though, that must be done through the UI. If you delete a file out of your library, Fireshare will not delete it's database entry until the user has specifically told it to from the UI as a safety feature. If a drive doesn't mount correctly or someone accidentally moves a folder, that's no different than a file being deleted. So I can't have fireshare automatically remove entries from it's database unless a user tells it to.

File renaming would be a great start! I know this is a spare time project so I appreciate any of your work.

[dammitjeff]

I think "Start Manual scan for games" could be better documented, as if a user has their folders setup properly for your app, it shouldn't be required much - if at all - I don't think?

Great news, work on this is currently underway in #444 :)