From b1c6abe4484f2800aa938e3ca8f8c57b819a152b Mon Sep 17 00:00:00 2001
From: Six Ash <six.ash@shopify.com>
Date: Wed, 12 Feb 2025 19:56:39 -0500
Subject: [PATCH] test helper shouldn't silently swallow errors

---
 packages/theme-check-common/src/test/test-helper.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/theme-check-common/src/test/test-helper.ts b/packages/theme-check-common/src/test/test-helper.ts
index b13760649..bc4e4615b 100644
--- a/packages/theme-check-common/src/test/test-helper.ts
+++ b/packages/theme-check-common/src/test/test-helper.ts
@@ -39,7 +39,7 @@ export function getTheme(themeDesc: MockTheme): Theme {
 
 export async function check(
   themeDesc: MockTheme,
-  checks: CheckDefinition<SourceCodeType>[] = recommended,
+  checks: CheckDefinition[] = recommended,
   mockDependencies: Partial<Dependencies> = {},
   checkSettings: ChecksSettings = {},
 ): Promise<Offense[]> {
@@ -47,8 +47,11 @@ export async function check(
   const config: Config = {
     context: 'theme',
     settings: { ...checkSettings },
-    checks: checks,
+    checks,
     rootUri,
+    onError: (err) => {
+      throw err;
+    },
   };
 
   const sections = new Map(