Tab List does not update on reload

[Peashooter101]

Plugin/Mod/Project Version

3.0.0

Minecraft / Server Version

1.21.10

What went wrong?

The tab list does not update on reload when the tab list setting is reloaded.

Frequency is extremely low since this is a configuration setting and likely would not be changed often. This may happen once per lifetime of a server just for the sake of seeing what it may look like.

This would definitely be an extremely low priority fix (also a good first issue for contributors outside of Simplexity) but the plugin should still not operate this way.

How can we reproduce this?

1. Set a nickname with the tab list setting off.
2. Set the tab list setting on and reload the plugin.
3. Open the player tab list, notice things have not changed.

You can also do this the other way (having a nickname set and turning off the tab list setting).

Relevant Logs

Other Plugins

No response

Checklist

• I’m using the latest version
• I’ve checked the existing issues

[rudrat0319]

Hi! I'd like to look into this issue.

I understand the problem: the tab list doesn't update on reload when the tab list setting is changed. I’ll try to reproduce it using the steps you've described and investigate where the configuration reload logic may not be refreshing the player tab data.

Before I start, could you point me to the part of the codebase responsible for:

• loading the tab list config
• applying tab list updates to players?

That will help me get oriented.
If the issue is still open, I'd be happy to work on it!

[Peashooter101]

@rudrat0319
You can find the reload command in simplexity.simplenicks.commands.subcommands.basic.ReloadSubCommand.
You can find the refresh logic in simplexity.simplenicks.logic.NickUtils in the refreshDisplayName method, however it may be optimal to have a new method specifically focused on refreshing all online users in the tab list.

If you have any more questions, please feel free to join our Discord at https://discord.gg/qe3YQrbegA

[rudrat0319]

@Peashooter101 Thanks for the discord link I've joined it. can u pls assign this issue to me?

[Peashooter101]

@rudrat0319 We do not do that for developers outside of Simplexity at this time, there isn't much of a reason to.

You would just pull request your changes in with "Resolves #(issue number)" to submit a fix for an issue.

See #14.