Item add on ground by script or by ther server do not decay

[Jhobean]

If you make appear an arrow on the ground with this function, TIMER will be -1 and ATTR_decay will not be set.

AN item appearing on the floor create by server should decay.

[FUNCTION test]
serv.newitem i_arrow
new.p=<src.p>
new.attr= attr_decay

[Jhobean]

I added these 2 line and it work

CItem* pItem = static_cast<CItem*>(this);
pItem->SetTimeout(pItem->GetDecayTime());    // Set it's timer to the real decay, in case it gets drop on ground.

But in debug many time I hit the break point. Sometime it's for blood. Blood already have timer and decay flag. That mean this line is useless on some situation.

I don't really know where I can add the check.

[mtwango]

Maybe instead of this try to swap MoveTo(pt) to MoveToDecay(pt, GetDecayTime())

[Jhobean]

I dont see where I can do that.

On the call stack, it seem to directly go to MOVETO or OV_P because I manually set the position

[mtwango]

if (pt.IsValidPoint())
{
    RemoveFromView();
    CItem *pItem = dynamic_cast<CItem *>(this);
    if (pItem)
        pItem->MoveToDecay(pt, pItem->GetDecayTime());
    else
        MoveTo(pt);

    Update();
}

[Jhobean]

work nice THX! I'll create a PR

[mtwango]

This is more global issue than it seems. it will probably be on movenear and other functions.

[Jhobean]

True! Explain probably why some timer -1 item was found everywhere random on the map

[cbnolok]

Should be fixed at least on dev

[Jhobean]

@cbnolok was fixed on this?
4ae948f)

I'll update my PR because apparetly my fix was not correct.

[cbnolok]

No it should have already been fixed since some commits ago