Merge pull request #72 from StackStorm/clean-up

Clean up a few things

Author: blag

.gitignore

@@ -56,3 +56,4 @@ node_modules
 
 # Custom
 dist
+package-lock.json

package.json

@@ -1,6 +1,6 @@
 {
   "name": "st2client",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "StackStorm ST2 API library",
   "main": "index.js",
   "scripts": {
@@ -31,9 +31,14 @@
   "engine": {
     "node": ">=0.11.0"
   },
+  "files": [
+    "/index.js",
+    "/lib"
+  ],
   "dependencies": {
     "axios": "^0.7.0",
     "eventsource": "^0.1.4",
+    "lodash": "^4.17.15",
     "object.assign": "^1.0.1"
   },
   "devDependencies": {

tests/test-attributable.js

@@ -45,7 +45,8 @@ describe('Attributable', function () {
 
       var result = api.attribute(1, 'some', {token: 'token-aaaa'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });
@@ -59,7 +60,8 @@ describe('Attributable', function () {
 
       var result = api.attribute(1, 'some', {key: 'key-cccc'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });

tests/test-deletable.js

@@ -45,7 +45,8 @@ describe('Deletable', function () {
 
       var result = api.delete(1, {token: 'token-aaaa'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });
@@ -59,7 +60,8 @@ describe('Deletable', function () {
 
       var result = api.delete(1, {key: 'key-cccc'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });

tests/test-editable.js

@@ -130,7 +130,8 @@ describe('Editable', function () {
 
       var result = api.edit(ref, request, query, {token: 'token-aaaa'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });
@@ -154,7 +155,8 @@ describe('Editable', function () {
 
       var result = api.edit(ref, request, query, {key: 'key-cccc'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });

tests/test-endpoint.js

@@ -2,7 +2,6 @@
 'use strict';
 
 var expect = require('chai').expect
-  , EventEmitter = require('events')
   , nock = require('nock')
   ;
 
@@ -90,7 +89,7 @@ describe('Endpoint', function () {
 
       var test_endpoint = Object.create({}, {test: test_endpoint_descriptor});
 
-      var scope = nock('http://localhost:8080')
+      nock('http://localhost:8080')
         .get('/test')
         .matchHeader('x-auth-token', 'token-aaaa')
         .reply(200, {});
@@ -135,7 +134,7 @@ describe('Endpoint', function () {
 
       var test_endpoint = Object.create({}, {test: test_endpoint_descriptor});
 
-      var scope = nock('http://localhost:8080')
+      nock('http://localhost:8080')
         .get('/test')
         .matchHeader('st2-api-key', 'key-cccc')
         .reply(200, {});

tests/test-enumerable.js

@@ -63,7 +63,8 @@ describe('Enumerable', function () {
 
       var result = api.listAll({ a: 'b' }, {token: 'token-aaaa'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });
@@ -78,7 +79,8 @@ describe('Enumerable', function () {
 
       var result = api.listAll({ a: 'b' }, {key: 'key-cccc'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });

tests/test-paginatable.js

@@ -151,7 +151,8 @@ describe('Paginatable', function () {
 
       var result = api.listPage(5, { a: 'b', limit: 100 }, {token: 'token-aaaa'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });
@@ -166,7 +167,8 @@ describe('Paginatable', function () {
 
       var result = api.listPage(5, { a: 'b', limit: 100 }, {key: 'key-cccc'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });

tests/test-readable.js

@@ -45,7 +45,8 @@ describe('Readable', function () {
 
       var result = api.get(1, {a: 'b'}, {token: 'token-aaaa'});
 
-      result.then(function (response) {
+      result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });
@@ -59,7 +60,8 @@ describe('Readable', function () {
 
       var result = api.get(1, {a: 'b'}, {key: 'key-cccc'});
 
-      result.then(function (response) {
+      result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });

tests/test-repeatable.js

@@ -55,7 +55,8 @@ describe('Repeatable', function () {
 
       var result = api.repeat(id, request, 'test', {token: 'token-aaaa'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });
@@ -72,7 +73,8 @@ describe('Repeatable', function () {
 
       var result = api.repeat(id, request, 'test', {key: 'key-cccc'});
 
-      return result.then(function (response) {
+      return result.then(function () {
+        /* jshint expr: true */
         expect(mock.isDone()).to.be.true;
       });
     });