Skip to content

feat: review sink reactions #81

@sulheim

Description

@sulheim

Description of the issue:

There are currently 26 sink reactions in the model:

DM_2hymeph_c
DM_2mborn_c
DM_33biflav_c
DM_38biflav_c
DM_4crsol_c
DM_5drib_c
DM_ACT_c
DM_RED_c
DM_aacald_c
DM_acetone_c
DM_aconm_c
DM_ahop_c
DM_albflon_c
DM_amob_c
DM_dalua_c
DM_ectoine__L_c
DM_geosmin_c
DM_germicidinA_c
DM_germicidinB_c
DM_germicidinC_c
DM_germicidinD_c
DM_grmcrnd_c
DM_mmyA_c
DM_mmyB_c
DM_msh_c
DM_strprub_c

At least the sink reactions for red and act can be removed as there are transport and proper exchange reactions for these compounds. I suggest to do a full review to see

  • Which sink reactions can be removed immediately, and remove them
  • Search for transport reactions for the other compunds to see if some of the sink reactions can be replaced by transport and exchange reactions.

I hereby confirm that:

  • This problem persists in the master branch of the repository
  • A similar issue does not already exist
  • I've considered asking this first in the Gitter chat room

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions