Skip to content

Commit 3f5ff37

Browse files
committed
CLAP-246 Refactor: 로그 서비스 생성
1 parent 3c90b31 commit 3f5ff37

File tree

6 files changed

+17
-69
lines changed

6 files changed

+17
-69
lines changed

src/main/java/clap/server/adapter/outbound/persistense/ApiLogPersistenceAdapter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import lombok.RequiredArgsConstructor;
1717
import org.springframework.data.domain.Page;
1818
import org.springframework.data.domain.Pageable;
19+
import org.springframework.transaction.annotation.Transactional;
1920

2021

2122
@PersistenceAdapter
@@ -28,6 +29,7 @@ public class ApiLogPersistenceAdapter implements CommandLogPort, LoadLogPort {
2829
private final ApiLogPersistenceMapper apiLogPersistenceMapper;
2930
private final MemberPersistenceMapper memberPersistenceMapper;
3031

32+
@Transactional
3133
@Override
3234
public void saveMemberLog(MemberLog memberLog) {
3335
apiLogRepository.save(apiLogPersistenceMapper.mapMemberLogToEntity(memberLog, memberPersistenceMapper.toEntity(memberLog.getMember())));

src/main/java/clap/server/application/service/log/CreateMemberLogsService.java renamed to src/main/java/clap/server/application/port/inbound/domain/LogService.java

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,27 @@
1-
package clap.server.application.service.log;
1+
package clap.server.application.port.inbound.domain;
22

3-
import clap.server.adapter.outbound.persistense.ApiLogPersistenceAdapter;
43
import clap.server.adapter.outbound.persistense.entity.log.constant.LogStatus;
5-
import clap.server.application.port.inbound.domain.MemberService;
6-
import clap.server.application.port.inbound.log.CreateMemberLogsUsecase;
74
import clap.server.application.port.outbound.log.CommandLogPort;
8-
import clap.server.common.annotation.architecture.ApplicationService;
5+
import clap.server.domain.model.log.AnonymousLog;
96
import clap.server.domain.model.log.MemberLog;
107
import clap.server.domain.model.member.Member;
118
import jakarta.servlet.http.HttpServletRequest;
12-
import jakarta.servlet.http.HttpServletResponse;
139
import lombok.RequiredArgsConstructor;
10+
import org.springframework.stereotype.Service;
1411
import org.springframework.transaction.annotation.Transactional;
1512

16-
import java.time.LocalDateTime;
17-
18-
@ApplicationService
13+
@Service
1914
@RequiredArgsConstructor
20-
public class CreateMemberLogsService implements CreateMemberLogsUsecase {
21-
15+
@Transactional
16+
public class LogService {
2217
private final CommandLogPort commandLogPort;
2318
private final MemberService memberService;
2419

25-
@Override
26-
@Transactional
20+
public void createAnonymousLog(HttpServletRequest request, int statusCode, String customCode, LogStatus logStatus, Object responseBody, String requestBody, String nickName) {
21+
AnonymousLog anonymousLog = AnonymousLog.createAnonymousLog(request, statusCode,customCode, logStatus, responseBody, requestBody, nickName);
22+
commandLogPort.saveAnonymousLog(anonymousLog);
23+
}
24+
2725
public void createMemberLog(HttpServletRequest request, int statusCode, String customCode,LogStatus logStatus, Object responseBody, String requestBody, Long userId) {
2826
Member member = memberService.findById(userId);
2927
MemberLog memberLog = MemberLog.createMemberLog(request, statusCode, customCode, logStatus, responseBody, requestBody, member);

src/main/java/clap/server/application/port/inbound/log/CreateAnonymousLogsUsecase.java

Lines changed: 0 additions & 12 deletions
This file was deleted.

src/main/java/clap/server/application/port/inbound/log/CreateMemberLogsUsecase.java

Lines changed: 0 additions & 12 deletions
This file was deleted.

src/main/java/clap/server/application/service/log/CreateAnonymousLogsService.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/main/java/clap/server/config/aop/LoggingAspect.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
import clap.server.adapter.inbound.security.service.SecurityUserDetails;
44

55
import clap.server.adapter.outbound.persistense.entity.log.constant.LogStatus;
6-
import clap.server.application.port.inbound.log.CreateAnonymousLogsUsecase;
7-
import clap.server.application.port.inbound.log.CreateMemberLogsUsecase;
6+
import clap.server.application.port.inbound.domain.LogService;
87
import clap.server.common.annotation.log.LogType;
98
import clap.server.exception.BaseException;
109
import com.fasterxml.jackson.databind.JsonNode;
@@ -35,9 +34,8 @@
3534
@RequiredArgsConstructor
3635
public class LoggingAspect {
3736
private final ObjectMapper objectMapper;
38-
private final CreateAnonymousLogsUsecase createAnonymousLogsUsecase;
39-
private final CreateMemberLogsUsecase createMemberLogsUsecase;
4037
private final HandlerExceptionResolver handlerExceptionResolver;
38+
private final LogService logService;
4139

4240
@Pointcut("execution(* clap.server.adapter.inbound.web..*Controller.*(..))")
4341
public void controllerMethods() {
@@ -74,14 +72,14 @@ public Object logApiRequests(ProceedingJoinPoint joinPoint) throws Throwable {
7472

7573
if (logStatus != null) {
7674
if (LogStatus.LOGIN.equals(logStatus)) {
77-
createAnonymousLogsUsecase.createAnonymousLog(request, statusCode, customCode, logStatus, result, getRequestBody(request), getNicknameFromRequestBody(request));
75+
logService.createAnonymousLog(request, statusCode, customCode, logStatus, result, getRequestBody(request), getNicknameFromRequestBody(request));
7876
} else {
7977
if (!isUserAuthenticated()) {
8078
log.error("로그인 시도 로그를 기록할 수 없음");
8179
} else {
8280
Object principal = SecurityContextHolder.getContext().getAuthentication().getPrincipal();
8381
if (principal instanceof SecurityUserDetails userDetails) {
84-
createMemberLogsUsecase.createMemberLog(request, statusCode, customCode, logStatus, result, getRequestBody(request), userDetails.getUserId());
82+
logService.createMemberLog(request, statusCode, customCode, logStatus, result, getRequestBody(request), userDetails.getUserId());
8583
}
8684
}
8785
}

0 commit comments

Comments
 (0)