From a0752e6ab9ca582e06fb1722af750136b01bffb2 Mon Sep 17 00:00:00 2001 From: oneroyalace Date: Tue, 16 Aug 2022 16:28:28 -0400 Subject: [PATCH] Speed up Facebook media source tests * Reuse facebook post data when possible so we don't need to keep scraping the same pages * Choose a shorter video for our scraping tests --- test/media_sources/facebook_media_source_test.rb | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/test/media_sources/facebook_media_source_test.rb b/test/media_sources/facebook_media_source_test.rb index 4506852..b0f62b3 100644 --- a/test/media_sources/facebook_media_source_test.rb +++ b/test/media_sources/facebook_media_source_test.rb @@ -2,6 +2,8 @@ class FacebookMediaSourceTest < ActiveSupport::TestCase def setup; end + @@facebook_image_post_array = FacebookMediaSource.extract(Scrape.create({ url: "https://www.facebook.com/photo/?fbid=10161587852468065&set=a.10150148489178065" })) + @@facebook_video_post_array = FacebookMediaSource.extract(Scrape.create({ url: "https://www.facebook.com/Meta/videos/264436895517475" })) test "can send error via slack notification" do assert_nothing_raised do @@ -23,19 +25,18 @@ def setup; end end test "extracted video has screenshot" do - posts = FacebookMediaSource.extract(Scrape.create({ url: "https://www.facebook.com/photo/?fbid=10161587852468065&set=a.10150148489178065" })) - posts.each { |post| assert_not_nil(post.screenshot_file) } + assert_not_nil @@facebook_video_post_array.first.screenshot_file end test "extracted post has images and videos uploaded to S3" do skip unless ENV["AWS_REGION"].present? - posts = FacebookMediaSource.extract(Scrape.create({ url: "https://www.facebook.com/photo/?fbid=10161587852468065&set=a.10150148489178065" })) + posts = @@facebook_image_post_array assert_not_nil(posts) posts.each { |post| assert_not_nil(post.aws_image_keys) } - posts = FacebookMediaSource.extract(Scrape.create({ url: "https://www.facebook.com/PlandemicMovie/videos/588866298398729/" })) + posts = @@facebook_video_post_array assert_not_nil(posts) posts.each { |post| assert_not_nil(post.aws_video_key) } @@ -55,8 +56,11 @@ def setup; end assert_not_nil(posts) posts.each { |post| assert_nil(post.aws_image_keys) } + posts.each { |post| assert_nil(post.aws_video_key) } + posts.each { |post| assert_nil(post.aws_video_preview_key) } + posts.each { |post| assert_nil(post.aws_screenshot_key) } - posts = FacebookMediaSource.extract(Scrape.create({ url: "https://www.facebook.com/PlandemicMovie/videos/588866298398729/" })) + posts = FacebookMediaSource.extract(Scrape.create({ url: "https://www.facebook.com/Meta/videos/264436895517475" })) assert_not_nil(posts) posts.each { |post| assert_nil(post.aws_image_keys) }