Skip to content

Build issue #1

@usptact

Description

@usptact

Trying to build the C++ application using CMake:

First, had to disable a couple unit tests since they don't exist:

diff --git a/maptree/tests/CMakeLists.txt b/maptree/tests/CMakeLists.txt
index 735dfb8..5a1ea8d 100644
--- a/maptree/tests/CMakeLists.txt
+++ b/maptree/tests/CMakeLists.txt
@@ -4,10 +4,6 @@ set(TESTFILES
     main.cpp
     bcart/test_bcart_utils.cpp
     search/test_search.cpp
-    data/test_fixed_bitset.cpp
-    data/test_rnumber.cpp
-    data/test_bitset.cpp
-    data/test_data_manager.cpp
 )

 set(TEST_MAIN unit_tests)

Finally, trying to build with GCC12 gives me this error:

...
[ 66%] Built target engine
[ 72%] Building CXX object CMakeFiles/main.dir/app/main.cpp.o
/Users/vlad/git/maptree/maptree/app/main.cpp: In function 'int main(int, char**)':
/Users/vlad/git/maptree/maptree/app/main.cpp:60:69: error: no matching function for call to 'BestFirstSearchMAPSearch::BestFirstSearchMAPSearch(std::vector<std::vector<bool> >&, std::vector<bool>&, double&, double&, std::array<double, 2>&)'
   60 |   BestFirstSearchMAPSearch search(features, labels, alpha, beta, rho);
      |                                                                     ^
In file included from /Users/vlad/git/maptree/maptree/app/main.cpp:9:
/Users/vlad/git/maptree/maptree/include/search/befs_map_search.h:103:9: note: candidate: 'BestFirstSearchMAPSearch::BestFirstSearchMAPSearch(const DataManager&, const TreeLikelihood&, const TreePrior&, int, int)'
  103 |         BestFirstSearchMAPSearch(
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
/Users/vlad/git/maptree/maptree/include/search/befs_map_search.h:104:32: note:   no known conversion for argument 1 from 'std::vector<std::vector<bool> >' to 'const DataManager&'
  104 |             const DataManager& dm,
      |             ~~~~~~~~~~~~~~~~~~~^~
/Users/vlad/git/maptree/maptree/include/search/befs_map_search.h:98:7: note: candidate: 'BestFirstSearchMAPSearch::BestFirstSearchMAPSearch(const BestFirstSearchMAPSearch&)'
   98 | class BestFirstSearchMAPSearch : BaseMAPSearch {
      |       ^~~~~~~~~~~~~~~~~~~~~~~~
/Users/vlad/git/maptree/maptree/include/search/befs_map_search.h:98:7: note:   candidate expects 1 argument, 5 provided
make[2]: *** [CMakeFiles/main.dir/app/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/main.dir/all] Error 2
make: *** [all] Error 2

My build steps:

cd maptree
mkdir build
cd build
cmake ..
make

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions