[release/6000.x] 'UniversalRenderPipeline.RenderSingleCamera(ScriptableRenderContext, Camera)' is obsolete

[tomas-bubenicek-fr]

Opening the branch targiting the correct version in Unity 6000.0.45f1 throws this warning:

Packages\com.verasl.water-system\Scripts\Rendering\PlanarReflections.cs(264,13): warning CS0618: 'UniversalRenderPipeline.RenderSingleCamera(ScriptableRenderContext, Camera)' is obsolete:
'RenderSingleCamera is obsolete, please use RenderPipeline.SubmitRenderRequest with UniversalRenderer.SingleCameraRequest as RequestData type'

After manually replacing this with the code recommended by the warning message like this:

var requestData = new UniversalRenderPipeline.StandardRequest{
    destination = _reflectionTexture
};
if (RenderPipeline.SupportsRenderRequest(_reflectionCamera, requestData)) {
    RenderPipeline.SubmitRenderRequest(_reflectionCamera, requestData);
}

It throws an even more severe error message

Recursive rendering is not supported in SRP (are you calling Camera.Render or RenderPipeline.SubmitRenderRequest from within a render pipeline?).

This is also mentioned in this this bug report forum discussion from 2022, but still seems to be present in current versions

[Torgo13]

Here is how the package from release/6000.3 branch can be updated:

1. In PlanarReflections.cs, remove the following lines:
   a. RenderPipelineManager.beginCameraRendering += ExecutePlanarReflections;
   b. RenderPipelineManager.beginCameraRendering -= ExecutePlanarReflections;
2. Change the ExecutePlanarReflections() functions from private to public
3. In Water.cs, add the following line at the beginning of BeginCameraRendering()
   a. _planarReflections?.ExecutePlanarReflections(src, cam);
4. In PlanarReflections.cs, add the following line at the beginning of ExecutePlanarReflections():
   a. if (camera == _reflectionCamera) return
5. Replace the following line with the code below:
   a. UniversalRenderPipeline.RenderSingleCamera(context, _reflectionCamera);

// Create a standard request
var request = new RenderPipeline.StandardRequest();

// Check if the request is supported by the active render pipeline
if (RenderPipeline.SupportsRenderRequest(_reflectionCamera, request))
{
    // Submit the render request to the active render pipeline with different destination textures
    request.destination = _reflectionCamera.targetTexture;

    // Render camera and fill texture2D with its view
    RenderPipeline.SubmitRenderRequest(_reflectionCamera, request);
}