@@ -35,7 +35,7 @@ rimraf(userDataDir, () => {})
3535// Access chrome object in Extensions
3636// https://github.com/GoogleChrome/puppeteer/issues/2878
3737
38- const EXT_LOAD_DELAY = 100
38+ const EXT_LOAD_DELAY = 2000
3939const extPopupHtml = 'popup.html'
4040const port = process . env . TEST_SERVER_PORT || 1337
4141let browser , bgPage , page , expressServerListener
@@ -45,7 +45,7 @@ let launchBrowser = () =>
4545 headless : false ,
4646 devtools : false ,
4747 dumpio : true ,
48- product : 'firefox ' ,
48+ product : 'chrome ' ,
4949 args : [
5050 `--disable-extensions-except=${ extPath } ` ,
5151 `--load-extension=${ extPath } ` ,
@@ -78,15 +78,15 @@ let setupBrowser = async ({ showPopup }) => {
7878
7979 if ( showPopup ) {
8080 await page . goto ( `chrome-extension://${ extID } /${ extPopupHtml } ` )
81- await page . waitFor ( 3000 )
81+ await page . waitForTimeout ( 3000 )
8282 await page . reload ( )
8383 await page . tracing . start ( {
8484 path : path . resolve ( `./automated_tests/traces/trace.json` ) ,
8585 } )
8686 }
8787
8888 // wait for page to load
89- await page . waitFor ( 3000 )
89+ await page . waitForTimeout ( 3000 )
9090 const backgroundPageTarget = targets . find (
9191 target => target . type ( ) === 'background_page' ,
9292 )
@@ -104,7 +104,7 @@ describe('chrome extension', () => {
104104 const logicTests = argv . logic ? getLogicTests ( argv . whitelist ) : [ ]
105105 const e2eTests = argv . e2e ? getE2eTests ( argv . whitelist ) : [ ]
106106 const ghostTests = argv . ghost ? getGhostTests ( argv . whitelist ) : [ ]
107- const allTests = [ ...logicTests , ...e2eTests , ...ghostTests ]
107+ const allTests = [ ...e2eTests , ...logicTests , ...ghostTests ]
108108
109109 for ( let t of allTests ) {
110110 // eslint-disable-next-line no-loop-func
@@ -115,7 +115,10 @@ describe('chrome extension', () => {
115115
116116 if ( t . eval ) {
117117 const evalRes = await bgPage . evaluate ( t . eval , {
118- testUser : global . TEST_USER ,
118+ testUser : {
119+ username : process . env . TEST_USER ,
120+ password : process . env . TEST_PASSWORD ,
121+ } ,
119122 } )
120123 t . assert ( evalRes )
121124 }
@@ -129,7 +132,7 @@ describe('chrome extension', () => {
129132 await screenshot ( page , t . name )
130133 }
131134
132- await page . waitFor ( 500 )
135+ await page . waitForTimeout ( 500 )
133136 } )
134137 }
135138
0 commit comments