Skip to content

Commit 94691c6

Browse files
committed
fix test
1 parent 3403b66 commit 94691c6

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

consensus/XDPoS/engines/engine_v2/utils.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,8 @@ func (x *XDPoS_v2) countValidSignatures(messageHash common.Hash, signatures []ty
137137
if _, ok := keys[pubkeyHex]; !ok {
138138
keys[pubkeyHex] = true
139139
} else {
140-
log.Warn("[verifySignatures] duplicate signing found", "pubkey", pubkeyHex, "signature", sig, "signedMessage", messageHash.Hex())
141-
return 0, fmt.Errorf("duplicate signing found, pubkey: %v, signature: %v", pubkeyHex, common.Bytes2Hex(sig))
140+
log.Warn("[verifySignatures] duplicate signing found", "pubkey", pubkeyHex, "signedMessage", messageHash.Hex(), "signature", sig)
141+
return 0, fmt.Errorf("duplicate signing found, pubkey: %v, message: %v, signature: %v", pubkeyHex, messageHash.Hex(), common.Bytes2Hex(sig))
142142
}
143143
}
144144

consensus/tests/engine_v2_tests/verify_header_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,8 +404,7 @@ func TestShouldFailIfNotEnoughQCSignatures(t *testing.T) {
404404
headerWithDuplicatedSignatures.Extra = extraInBytes
405405
// Happy path
406406
err = adaptor.VerifyHeader(blockchain, headerWithDuplicatedSignatures, true)
407-
assert.Equal(t, utils.ErrInvalidQCSignatures, err)
408-
407+
assert.ErrorContains(t, err, "duplicate signing found")
409408
}
410409

411410
func TestShouldVerifyHeaders(t *testing.T) {

0 commit comments

Comments
 (0)