Autoupdater correctly updates manifest version only if checks the 'main' ressource - feature or bug?

[oleole39]

Hello,

Say you declare following source in the manifest:

[resources.sources.upstream]
# This is not used as we are using git clone. It's only here for autoupdate.
url = "https://github.com/AykutSarac/jsoncrack.com/archive/2925b9d2cf679f461d5c8dc0174d37ee9e6c0e5d.tar.gz"
sha256 = "95f83ce9665278eaa8a96cfc6aad4cce1d187a6b2f6ddbbf2ae52eff78aef963"
prefetch = false
autoupdate.strategy = "latest_github_commit"

At next upstream update found, autoupdate_app_sources.py will provide update manifest version by updating only the YNH package version instead of the main version.
This is due to the fact that the source to which autoupdate property is applied is not named main (but upstream in the given example):

apps_tools/autoupdate_app_sources/autoupdate_app_sources.py

Line 245 in 7603de3

is_main=source == "main",

• If this is to be considered as a feature, I guess it should be added to the documentation: autoupdate property only works correctly with source named main doc#2583
• If this is to be considered as a bug, I haven't worked on it so far.

[Salamandar]

Feature !
The "main" resource is expected to be… the "main" resource, the one that downloads the sources of the core of the app.

That should be documented indeed… I keep this issue open as a reminder.

[oleole39]

That should be documented indeed… I keep this issue open as a reminder.

Note that I had also created that related PR to doc for such case if you wish: YunoHost/doc#2583

The "main" resource is expected to be… the "main" resource, the one that downloads the sources of the core of the app.

Not a big deal as if documented it can be easily composed with, but note that such meaning will not be universal as in some cases you may not have in mind yet, we want to use one given resource to update the manifest which is the nevertheless not the one we want to install. Cf. for instance the model of jsoncrack_ynh (which triggered opening that issue) which provides a way to automatically build (via Github infra) and update manifest from the "main" resource, but only install the "built" resource (the goal here is to reduce the local hardware resources required for an app to be built granted that nodeJS package are very resource-intensive to build).
In such case, it make it clearer to trigger autoupdate on a resource called "upstream" but install "main" resources (or the "ynh_build" one). Of course this is simply a question of naming, and we can as well call the first one "main" even though we don't install it...