From 98427c76ec562216e48726991e8bbc1b8f3aec44 Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Mon, 9 Feb 2026 22:01:56 -0500 Subject: [PATCH 01/12] #863 Fix controller dash navbar formatting --- resources/views/inc/dashboard_head.blade.php | 37 +++++++++----------- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/resources/views/inc/dashboard_head.blade.php b/resources/views/inc/dashboard_head.blade.php index 4efd8d2aa..4e6188a0d 100644 --- a/resources/views/inc/dashboard_head.blade.php +++ b/resources/views/inc/dashboard_head.blade.php @@ -1,26 +1,23 @@ - + + + From 119d96aa3410ea40b2df42a61e1d2a521333a140 Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Mon, 9 Feb 2026 23:45:45 -0500 Subject: [PATCH 02/12] #863 Lay framework for impersonation --- app/Providers/AppServiceProvider.php | 4 +++ app/User.php | 12 ++++++++ app/View/Composers/ImpersonationComposer.php | 31 ++++++++++++++++++++ resources/views/inc/dashboard_head.blade.php | 21 ++++++++----- 4 files changed, 61 insertions(+), 7 deletions(-) create mode 100644 app/View/Composers/ImpersonationComposer.php diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php index 01e6b2750..d25d7db14 100644 --- a/app/Providers/AppServiceProvider.php +++ b/app/Providers/AppServiceProvider.php @@ -2,11 +2,13 @@ namespace App\Providers; +use App\View\Composers\ImpersonationComposer; use Illuminate\Pagination\LengthAwarePaginator; use Illuminate\Pagination\Paginator; use Illuminate\Support\Collection; use Illuminate\Support\Facades\Blade; use Illuminate\Support\Facades\Schema; +use Illuminate\Support\Facades\View; use Illuminate\Support\Facades\Vite; use Illuminate\Support\ServiceProvider; @@ -24,6 +26,8 @@ public function boot(): void { return toggleEnabled($toggle_name); }); + View::composer('inc.dashboard_head', ImpersonationComposer::class); + /** * Paginate a standard Laravel Collection. * diff --git a/app/User.php b/app/User.php index 08bb784ff..d25250103 100644 --- a/app/User.php +++ b/app/User.php @@ -73,6 +73,18 @@ public function getFullNameRatingAttribute() { return $this->full_name . ' - ' . $this->rating_short; } + public function getImpersonationNameAttribute() { + $roles = array_reduce($this->roles->toArray(), function ($role_string, $role) { + return $role_string . $role['name'] . ', '; + }, ''); + + if ($roles != '') { + $roles = ' (' . trim($roles, ', ') . ')'; + } + + return $this->full_name . ' ' . $this->id . ' - ' . $this->rating_short . $roles; + } + public static $RatingShort = [ 0 => 'N/A', 1 => 'OBS', 2 => 'S1', diff --git a/app/View/Composers/ImpersonationComposer.php b/app/View/Composers/ImpersonationComposer.php new file mode 100644 index 000000000..955685623 --- /dev/null +++ b/app/View/Composers/ImpersonationComposer.php @@ -0,0 +1,31 @@ +isAbleTo('snrStaff')) { + $users = User::get()->pluck('impersonation_name', 'id'); + } + + $view->with('users', $users)->with('is_impersonating', $is_impersonating); + } +} diff --git a/resources/views/inc/dashboard_head.blade.php b/resources/views/inc/dashboard_head.blade.php index 4e6188a0d..889343344 100644 --- a/resources/views/inc/dashboard_head.blade.php +++ b/resources/views/inc/dashboard_head.blade.php @@ -3,20 +3,27 @@ @include('inc.logo', ['color' => 'black']) -
- {{ html()->form()->route('searchAirport')->class(['row','row-cols-lg-auto'])->open() }} +
    + {{ html()->form()->route('searchAirport')->class(['form-inline'])->open() }}
    {{ html()->text('apt', null)->placeholder('Search Airport ICAO')->class(['form-control']) }}  
    {{ html()->form()->close() }} -
- + From bcf958ea3b5d5cb3c71f48174fb04cfdc8ed3bc9 Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Tue, 10 Feb 2026 10:23:03 -0500 Subject: [PATCH 03/12] #863 Add routes for impersonation and set session var --- .../Controllers/ImpersonationController.php | 24 +++++++++++++++++++ app/User.php | 2 +- app/View/Composers/ImpersonationComposer.php | 2 +- resources/views/inc/dashboard_head.blade.php | 6 ++--- routes/web.php | 5 ++++ 5 files changed, 34 insertions(+), 5 deletions(-) create mode 100644 app/Http/Controllers/ImpersonationController.php diff --git a/app/Http/Controllers/ImpersonationController.php b/app/Http/Controllers/ImpersonationController.php new file mode 100644 index 000000000..345ed2681 --- /dev/null +++ b/app/Http/Controllers/ImpersonationController.php @@ -0,0 +1,24 @@ +user_id); + if (is_null($user)) { + return redirect()->back()->with('error', 'That user does not exist'); + } + + session()->put('impersonate', $user->id); + return redirect('/dashboard'); + } + + public function stop() { + session()->forget('impersonate'); + return redirect('/dashboard'); + } +} diff --git a/app/User.php b/app/User.php index d25250103..b3168e93e 100644 --- a/app/User.php +++ b/app/User.php @@ -82,7 +82,7 @@ public function getImpersonationNameAttribute() { $roles = ' (' . trim($roles, ', ') . ')'; } - return $this->full_name . ' ' . $this->id . ' - ' . $this->rating_short . $roles; + return $this->backwards_name . ' ' . $this->id . ' - ' . $this->rating_short . $roles; } public static $RatingShort = [ diff --git a/app/View/Composers/ImpersonationComposer.php b/app/View/Composers/ImpersonationComposer.php index 955685623..e67529d5e 100644 --- a/app/View/Composers/ImpersonationComposer.php +++ b/app/View/Composers/ImpersonationComposer.php @@ -23,7 +23,7 @@ public function compose(View $view): void { $is_impersonating = false; if (Auth::user()->isAbleTo('snrStaff')) { - $users = User::get()->pluck('impersonation_name', 'id'); + $users = User::orderBy('lname', 'ASC')->get()->pluck('impersonation_name', 'id'); } $view->with('users', $users)->with('is_impersonating', $is_impersonating); diff --git a/resources/views/inc/dashboard_head.blade.php b/resources/views/inc/dashboard_head.blade.php index 889343344..7fff16dbc 100644 --- a/resources/views/inc/dashboard_head.blade.php +++ b/resources/views/inc/dashboard_head.blade.php @@ -15,11 +15,11 @@
    Dashboard Home @if($is_impersonating) - End Impersonation + End Impersonation @endif @if(Auth::user()->isAbleTo('snrStaff')) - {{ html()->form()->route('searchAirport')->class(['form-inline'])->open() }} - {{ html()->select('student', $users, Auth::id())->class(['form-select']) }} + {{ html()->form()->route('startImpersonation')->class(['form-inline'])->open() }} + {{ html()->select('user_id', $users, Auth::id())->class(['form-select'])->attributes(['onchange' => 'this.form.submit()']) }} {{ html()->form()->close() }} @else {{ Auth::user()->full_name }} - {{ Auth::user()->rating_short }} diff --git a/routes/web.php b/routes/web.php index 43187ccaa..24707364d 100644 --- a/routes/web.php +++ b/routes/web.php @@ -333,6 +333,11 @@ Route::prefix('monitor')->middleware('permission:staff')->group(function () { Route::get('/', 'AdminDash@backgroundMonitor'); }); + + Route::prefix('impersonation')->group(function() { + Route::post('/', 'ImpersonationController@start')->middleware('permission:snrStaff')->name('startImpersonation'); + Route::get('/stop', 'ImpersonationController@stop')->name('stopImpersonation'); + }); }); }); /* From cf3b301dc8943500e6e36e6c773f86771c18fc6c Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Tue, 10 Feb 2026 10:31:41 -0500 Subject: [PATCH 04/12] #863 Implement impersonation --- app/Http/Kernel.php | 1 + app/Http/Middleware/Impersonation.php | 25 ++++++++++++++++++++ app/View/Composers/ImpersonationComposer.php | 2 +- 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 app/Http/Middleware/Impersonation.php diff --git a/app/Http/Kernel.php b/app/Http/Kernel.php index 869e64d7e..a86084528 100644 --- a/app/Http/Kernel.php +++ b/app/Http/Kernel.php @@ -35,6 +35,7 @@ class Kernel extends HttpKernel { \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class, \App\Http\Middleware\VerifyCsrfToken::class, \Illuminate\Routing\Middleware\SubstituteBindings::class, + \App\Http\Middleware\Impersonation::class, ], 'api' => [ diff --git a/app/Http/Middleware/Impersonation.php b/app/Http/Middleware/Impersonation.php new file mode 100644 index 000000000..ef1753b63 --- /dev/null +++ b/app/Http/Middleware/Impersonation.php @@ -0,0 +1,25 @@ +has('impersonate') && Auth::user()->isAbleTo('snrStaff')) { + Auth::onceUsingId(session('impersonate')); + } + + return $next($request); + } +} diff --git a/app/View/Composers/ImpersonationComposer.php b/app/View/Composers/ImpersonationComposer.php index e67529d5e..93f693086 100644 --- a/app/View/Composers/ImpersonationComposer.php +++ b/app/View/Composers/ImpersonationComposer.php @@ -20,7 +20,7 @@ public function __construct( */ public function compose(View $view): void { $users = null; - $is_impersonating = false; + $is_impersonating = session()->has('impersonate'); if (Auth::user()->isAbleTo('snrStaff')) { $users = User::orderBy('lname', 'ASC')->get()->pluck('impersonation_name', 'id'); From e543e7b3eec3235fe8ffcc307d855784a3edb3ba Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Tue, 10 Feb 2026 10:35:30 -0500 Subject: [PATCH 05/12] #863 Add warning to users when impersonating --- app/Http/Controllers/ImpersonationController.php | 2 +- resources/views/inc/messages.blade.php | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/ImpersonationController.php b/app/Http/Controllers/ImpersonationController.php index 345ed2681..d70c1d0d1 100644 --- a/app/Http/Controllers/ImpersonationController.php +++ b/app/Http/Controllers/ImpersonationController.php @@ -14,7 +14,7 @@ public function start(Request $request) { } session()->put('impersonate', $user->id); - return redirect('/dashboard'); + return redirect('/dashboard')->with('warning', 'Successfully started impersonationg ' . $user->full_name . '. CAUTION: Impersonating actively logs you into the user\'s REAL account. Changes made while impersonating will be reflected on the user\'s actual account. PROCEED WITH CARE.'); } public function stop() { diff --git a/resources/views/inc/messages.blade.php b/resources/views/inc/messages.blade.php index 35a72786d..d50b64a62 100644 --- a/resources/views/inc/messages.blade.php +++ b/resources/views/inc/messages.blade.php @@ -17,6 +17,13 @@ @endif + @if(session('warning')) +
    +
    + {{ session('warning') }} +
    + @endif + @if(session('error'))
    From 5467ceebc6741478503ad7bd07a64b57573ac8eb Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Tue, 10 Feb 2026 11:32:55 -0500 Subject: [PATCH 06/12] #863 Filter out inactive users from impersonation --- app/View/Composers/ImpersonationComposer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/View/Composers/ImpersonationComposer.php b/app/View/Composers/ImpersonationComposer.php index 93f693086..43e2c849c 100644 --- a/app/View/Composers/ImpersonationComposer.php +++ b/app/View/Composers/ImpersonationComposer.php @@ -23,7 +23,7 @@ public function compose(View $view): void { $is_impersonating = session()->has('impersonate'); if (Auth::user()->isAbleTo('snrStaff')) { - $users = User::orderBy('lname', 'ASC')->get()->pluck('impersonation_name', 'id'); + $users = User::where('status', 1)->orderBy('lname', 'ASC')->get()->pluck('impersonation_name', 'id'); } $view->with('users', $users)->with('is_impersonating', $is_impersonating); From ece842370c4af2fd90d9a4e3aea6e1aaaa89ecf7 Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Tue, 10 Feb 2026 11:34:28 -0500 Subject: [PATCH 07/12] #863 Add visitor flag to impersonation list --- app/User.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/User.php b/app/User.php index b3168e93e..837ac01e4 100644 --- a/app/User.php +++ b/app/User.php @@ -78,6 +78,10 @@ public function getImpersonationNameAttribute() { return $role_string . $role['name'] . ', '; }, ''); + if ($this->visitor) { + $roles = 'visitor'; + } + if ($roles != '') { $roles = ' (' . trim($roles, ', ') . ')'; } From 4347fa436673f432252c16286651727c0ecc0bc2 Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Tue, 10 Feb 2026 17:18:45 -0500 Subject: [PATCH 08/12] #863 Put impersonation behind feature toggle --- app/Http/Middleware/Impersonation.php | 6 +++--- app/View/Composers/ImpersonationComposer.php | 14 ++++++++------ resources/views/inc/dashboard_head.blade.php | 4 ++-- routes/web.php | 2 +- 4 files changed, 14 insertions(+), 12 deletions(-) diff --git a/app/Http/Middleware/Impersonation.php b/app/Http/Middleware/Impersonation.php index ef1753b63..ffd340c39 100644 --- a/app/Http/Middleware/Impersonation.php +++ b/app/Http/Middleware/Impersonation.php @@ -14,9 +14,9 @@ class Impersonation * * @param \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response) $next */ - public function handle(Request $request, Closure $next): Response - { - if (session()->has('impersonate') && Auth::user()->isAbleTo('snrStaff')) { + public function handle(Request $request, Closure $next): Response { + if (toggleEnabled('impersonation') && session()->has('impersonate') && Auth::user()->isAbleTo('snrStaff')) { + session()->put('impersonating_user', Auth::id()); Auth::onceUsingId(session('impersonate')); } diff --git a/app/View/Composers/ImpersonationComposer.php b/app/View/Composers/ImpersonationComposer.php index 43e2c849c..4d3d88d9e 100644 --- a/app/View/Composers/ImpersonationComposer.php +++ b/app/View/Composers/ImpersonationComposer.php @@ -19,13 +19,15 @@ public function __construct( * Bind data to the view. */ public function compose(View $view): void { - $users = null; - $is_impersonating = session()->has('impersonate'); + if (toggleEnabled('impersonation')) { + $users = null; + $is_impersonating = session()->has('impersonate'); - if (Auth::user()->isAbleTo('snrStaff')) { - $users = User::where('status', 1)->orderBy('lname', 'ASC')->get()->pluck('impersonation_name', 'id'); - } + if (Auth::user()->isAbleTo('snrStaff')) { + $users = User::where('status', 1)->orderBy('lname', 'ASC')->get()->pluck('impersonation_name', 'id'); + } - $view->with('users', $users)->with('is_impersonating', $is_impersonating); + $view->with('users', $users)->with('is_impersonating', $is_impersonating); + } } } diff --git a/resources/views/inc/dashboard_head.blade.php b/resources/views/inc/dashboard_head.blade.php index 7fff16dbc..be4ed0cfd 100644 --- a/resources/views/inc/dashboard_head.blade.php +++ b/resources/views/inc/dashboard_head.blade.php @@ -14,10 +14,10 @@
    Dashboard Home - @if($is_impersonating) + @if(toggleEnabled('impersonation') && $is_impersonating) End Impersonation @endif - @if(Auth::user()->isAbleTo('snrStaff')) + @if(toggleEnabled('impersonation') && Auth::user()->isAbleTo('snrStaff')) {{ html()->form()->route('startImpersonation')->class(['form-inline'])->open() }} {{ html()->select('user_id', $users, Auth::id())->class(['form-select'])->attributes(['onchange' => 'this.form.submit()']) }} {{ html()->form()->close() }} diff --git a/routes/web.php b/routes/web.php index 24707364d..3a6a1e7f5 100644 --- a/routes/web.php +++ b/routes/web.php @@ -334,7 +334,7 @@ Route::get('/', 'AdminDash@backgroundMonitor'); }); - Route::prefix('impersonation')->group(function() { + Route::prefix('impersonation')->middleware('toggle:impersonation')->group(function () { Route::post('/', 'ImpersonationController@start')->middleware('permission:snrStaff')->name('startImpersonation'); Route::get('/stop', 'ImpersonationController@stop')->name('stopImpersonation'); }); From 322f26d8e284218cc933b02169e3fe8888b57402 Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Sun, 15 Feb 2026 10:36:04 -0500 Subject: [PATCH 09/12] #863 Fix formatting --- app/Http/Controllers/ImpersonationController.php | 3 +-- app/Http/Middleware/Impersonation.php | 5 ++--- app/View/Composers/ImpersonationComposer.php | 1 - 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/app/Http/Controllers/ImpersonationController.php b/app/Http/Controllers/ImpersonationController.php index d70c1d0d1..ba387da9b 100644 --- a/app/Http/Controllers/ImpersonationController.php +++ b/app/Http/Controllers/ImpersonationController.php @@ -5,8 +5,7 @@ use App\User; use Illuminate\Http\Request; -class ImpersonationController extends Controller -{ +class ImpersonationController extends Controller { public function start(Request $request) { $user = User::find($request->user_id); if (is_null($user)) { diff --git a/app/Http/Middleware/Impersonation.php b/app/Http/Middleware/Impersonation.php index ffd340c39..880b45299 100644 --- a/app/Http/Middleware/Impersonation.php +++ b/app/Http/Middleware/Impersonation.php @@ -2,13 +2,12 @@ namespace App\Http\Middleware; +use Auth; use Closure; use Illuminate\Http\Request; use Symfony\Component\HttpFoundation\Response; -use Auth; -class Impersonation -{ +class Impersonation { /** * Handle an incoming request. * diff --git a/app/View/Composers/ImpersonationComposer.php b/app/View/Composers/ImpersonationComposer.php index 4d3d88d9e..97e347e53 100644 --- a/app/View/Composers/ImpersonationComposer.php +++ b/app/View/Composers/ImpersonationComposer.php @@ -5,7 +5,6 @@ use App\User; use Auth; use Illuminate\View\View; -use Laratrust\Models\Role; class ImpersonationComposer { /** From be8111bef7fa2f9aeba6dfbc7c563056b2b843e0 Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Sun, 15 Feb 2026 10:51:07 -0500 Subject: [PATCH 10/12] #863 Add impersonation to audit log --- app/Audit.php | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/app/Audit.php b/app/Audit.php index 86769df98..4e5a1b85e 100644 --- a/app/Audit.php +++ b/app/Audit.php @@ -17,10 +17,21 @@ public function getTimeDateAttribute() { } public static function newAudit(string $message): void { + $impersonated_by_id = null; + $impersonation_string = ''; + if (session()->has('impersonating_user')) { + $impersonated_by_id = session('impersonating_user'); + $impersonation_user = User::find($impersonated_by_id); + + $impersonation_string = 'IMPERSONATED BY ' . (is_null($impersonation_user) ? 'UNKNOWN' : $impersonation_user->full_name) . ': '; + } + $impersonated_by_id = session()->has('impersonating_user') ? session('impersonating_user') : null; + $audit = new Audit; $audit->cid = Auth::id(); + $audit->impersonated_by_id = $impersonated_by_id; $audit->ip = $_SERVER['REMOTE_ADDR']; - $audit->what = Auth::user()->full_name . ' ' . $message; + $audit->what = $impersonation_string . Auth::user()->full_name . ' ' . $message; $audit->save(); } } From d7838d28023b1a9c2016c828915c7523802f6a40 Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Sun, 15 Feb 2026 10:53:51 -0500 Subject: [PATCH 11/12] #863 Disable changing impersonation when impersonating --- app/Http/Controllers/ImpersonationController.php | 5 +++++ resources/views/inc/dashboard_head.blade.php | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/ImpersonationController.php b/app/Http/Controllers/ImpersonationController.php index ba387da9b..9e9159964 100644 --- a/app/Http/Controllers/ImpersonationController.php +++ b/app/Http/Controllers/ImpersonationController.php @@ -8,10 +8,15 @@ class ImpersonationController extends Controller { public function start(Request $request) { $user = User::find($request->user_id); + $is_impersonating = session()->has('impersonate'); if (is_null($user)) { return redirect()->back()->with('error', 'That user does not exist'); } + if ($is_impersonating) { + return redirect()->back()->with('error', 'You must first stop impersonating your current user before beginning a new session'); + } + session()->put('impersonate', $user->id); return redirect('/dashboard')->with('warning', 'Successfully started impersonationg ' . $user->full_name . '. CAUTION: Impersonating actively logs you into the user\'s REAL account. Changes made while impersonating will be reflected on the user\'s actual account. PROCEED WITH CARE.'); } diff --git a/resources/views/inc/dashboard_head.blade.php b/resources/views/inc/dashboard_head.blade.php index be4ed0cfd..ddfbcd3f5 100644 --- a/resources/views/inc/dashboard_head.blade.php +++ b/resources/views/inc/dashboard_head.blade.php @@ -19,7 +19,7 @@ @endif @if(toggleEnabled('impersonation') && Auth::user()->isAbleTo('snrStaff')) {{ html()->form()->route('startImpersonation')->class(['form-inline'])->open() }} - {{ html()->select('user_id', $users, Auth::id())->class(['form-select'])->attributes(['onchange' => 'this.form.submit()']) }} + {{ html()->select('user_id', $users, Auth::id())->class(['form-select'])->attributes(['onchange' => 'this.form.submit()'])->disabled($is_impersonating) }} {{ html()->form()->close() }} @else {{ Auth::user()->full_name }} - {{ Auth::user()->rating_short }} From 302d9fcca8d54f757e50077ff38f5caa558430db Mon Sep 17 00:00:00 2001 From: Ian Cowan Date: Sun, 15 Feb 2026 10:55:36 -0500 Subject: [PATCH 12/12] #863 Track impersonation start/end in audit log --- app/Http/Controllers/ImpersonationController.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/Http/Controllers/ImpersonationController.php b/app/Http/Controllers/ImpersonationController.php index 9e9159964..af688b507 100644 --- a/app/Http/Controllers/ImpersonationController.php +++ b/app/Http/Controllers/ImpersonationController.php @@ -2,6 +2,7 @@ namespace App\Http\Controllers; +use App\Audit; use App\User; use Illuminate\Http\Request; @@ -18,10 +19,14 @@ public function start(Request $request) { } session()->put('impersonate', $user->id); + + Audit::newAudit('started impersonating user ' . $user->impersonation_name . '.'); return redirect('/dashboard')->with('warning', 'Successfully started impersonationg ' . $user->full_name . '. CAUTION: Impersonating actively logs you into the user\'s REAL account. Changes made while impersonating will be reflected on the user\'s actual account. PROCEED WITH CARE.'); } public function stop() { + Audit::newAudit('impersonation session ending...'); + session()->forget('impersonate'); return redirect('/dashboard'); }