Skip to content

Container app upsert should not re-send existing revision suffix #9

@aarondandy

Description

@aarondandy

In the container apps appUpsert code, we get the model from the server, then apply a descriptor to the model we receive. In doing so, we will create a new model to send back to azure which should be the same data that came from azure with the descriptor modifications applied, as expected.

I think I finally hit a case where that is a problem though 😕. The container app template.revisionSuffix may be an exception to this rule. In cases where a revision suffix is not overridden within the upsert descriptor, we should not send the revisionSuffix back up to the server, causing it to be left alone, hopefully. In cases where it is explicitly set in a descriptor, that should of course go back to azure.

Symptoms

revision with suffix xxxxxxxxxxxxxx already exists.

Workaround

Explicitly send null in the descriptor:

{
  template: {
    revisionSuffix: null!,
  }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions