Skip to content

Missing definition of function check_sha256() in download.py #34

@IgnacioIrigaray

Description

@IgnacioIrigaray

While reviewing the download.py file in the DeepAFx-ST repository, I noticed that there is a reference to a function called check_sha256 in line 283, but I could not find any definition of this function in the codebase.

Details:

  • Affected file: download.py
  • Observed behavior: check_sha256(...) is invoked but the function is not defined anywhere in the repo nor imported from another module.
  • Possible consequence: downloaded files are not integrity-checked, which could allow corrupted or tampered files to pass unnoticed.

Additional context:

When running out of disk space during the Jamendo dataset download and later resuming decompression of the files, the process fails with an error. From looking at the code, it seems this happens because the missing check_sha256() function is supposed to handle verification/validation, but since it is undefined, corrupted partial files remain and the pipeline cannot recover properly.

Could you please confirm whether this function was accidentally omitted, or if it exists elsewhere in the repo.

Thanks,
Ignacio

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions