Adapting Pokemon Showdown #1
Description
This is a list of functions in the two Pokemon Showdown folders this project is adapting (sim and dex) that will, should, and might have its logic completely changed. The functions are also listed for their main reason for changing. To discuss a function in depth, a separate issue can be created directly from this list. I'll be editing this list as ideas change.
Priority 1 (Will Change)
- Battle.runEvent (and similar functions), Battle.findEventHandlers (and helper functions) [Performance] #3
- Battle.toJSON/fromJSON [Performance] (copying battle states was resolved by Battle.random/randomChance/sample [Functionality] #2)
- PRNG.sample [Functionality] (resolved by Battle.random/randomChance/sample [Functionality] #2)
- Battle.random/randomChance/sample [Functionality] #2
- Battle.speedSort [Functionality]
- Battle.getRequests/clearRequest [Functionality] #6
- Battle.randomizer [Functionality] (resolved by Battle.random/randomChance/sample [Functionality] #2)
- Battle.runAction [Functionality] #7
- Battle.go [Functionality] (resolved by Battle.random/randomChance/sample [Functionality] #2)
- BattleAction.hitStepMoveHitLoop [Functionality] #5
- BattleAction.secondaries [Functionality] #4
Priority 2 (Should Change)
- BattleQueue.resolveAction [Performance]
- BattleActions.useMove (and helper functions) [Performance][Functionality]
- Dex___.getByID [Performance]
- Pokemon.calculateStat/getStat [Performance]
- Battle.boost [Performance][Functionality]
- Battle.spreadDamage [Performance][Functionality]
- Side.chooseMove [Functionality]
- Side.chooseSwitch [Functionality]
- Side.chooseTeam [Functionality]
- Battle.start [Functionality]
Priority 3 (Might Change)
- ModdedDex.getEffectiveness [Performance][Functionality]
- Pokemon.transformInto [Performance][Functionality]
- Pokemon.setStatus [Performance]
- Pokemon.addVolatile [Performance]
- Pokemon.effectiveWeather [Performance]
- Pokemon.runEffectiveness [Performance]
- Pokemon.runImmunity [Performance]
- Pokemon.runStatusImmunity [Performance]
- Pokemon.transformInto [Functionality]