From 2ace723006552baf55b0ebdc677dc52dcf2ca939 Mon Sep 17 00:00:00 2001 From: Vladimir Yarotsky Date: Tue, 4 Feb 2020 16:36:57 -0800 Subject: [PATCH] Removes `status` from Version Updating deployment status causes a new version of the resource to be inserted by concourse and may trigger unwanted deployments. --- in_command.go | 8 +------- out_command.go | 8 +------- out_command_test.go | 3 +-- resources.go | 3 +-- 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/in_command.go b/in_command.go index 5768c22..248f1db 100644 --- a/in_command.go +++ b/in_command.go @@ -96,15 +96,9 @@ func (c *InCommand) Run(destDir string, request InRequest) (InResponse, error) { return InResponse{}, err } - latestStatus := "" - if len(statuses) > 0 { - latestStatus = *statuses[0].State - } - return InResponse{ Version: Version{ - ID: strconv.FormatInt(*deployment.ID, 10), - Statuses: latestStatus, + ID: strconv.FormatInt(*deployment.ID, 10), }, Metadata: metadataFromDeployment(deployment, statuses), }, nil diff --git a/out_command.go b/out_command.go index 56d9ada..3ece327 100644 --- a/out_command.go +++ b/out_command.go @@ -58,15 +58,9 @@ func (c *OutCommand) Run(sourceDir string, request OutRequest) (OutResponse, err return OutResponse{}, err } - latestStatus := "" - if len(statuses) > 0 { - latestStatus = *statuses[0].State - } - return OutResponse{ Version: Version{ - ID: *request.Params.ID, - Statuses: latestStatus, + ID: *request.Params.ID, }, Metadata: metadataFromDeployment(deployment, statuses), }, nil diff --git a/out_command_test.go b/out_command_test.go index 6e74c2c..391265f 100644 --- a/out_command_test.go +++ b/out_command_test.go @@ -110,8 +110,7 @@ var _ = Describe("Status Out Command", func() { Ω(outResponse.Version).Should(Equal( resource.Version{ - ID: "1234", - Statuses: "success", + ID: "1234", }, )) }) diff --git a/resources.go b/resources.go index cc1ddd3..134716f 100644 --- a/resources.go +++ b/resources.go @@ -20,8 +20,7 @@ type Source struct { } type Version struct { - ID string `json:"id"` - Statuses string `json:"status"` + ID string `json:"id"` } type CheckRequest struct {