Skip to content

Improve host/ligand_name/selection #32

@ale94mleon

Description

@ale94mleon

This may be confused. So it would be nice to have only one definition

  • *_name: is used for:
    • The creation of the index files and use the syntax of gmx make_ndx. At the moment, it uses the name of the group for the receptor but it can be easily extended.
    • By the function bindflow.utils.tools.center_xtc. This function is called on the equi.boresch and mmbpsa.ana to fix the trajectory before the analysis
  • *_selection is used at snakemake level when the Boresch restraint are selected. Here MDAnalysis is used, so the syntax is different to gmx make_ndx.

The best solution: only use one syntax either gmx make_ndx or MDAnalysis, define better naming and work with selection instead of group names. e.g.:

host_ndx_selection and host_boresch_selection

This allows more flexibility for the selection of the host for gmx_MMPBSA. One quick solution is to include the current host_selection keyword for mmpbsa calculations and create the index file at snakemake level (this solution has the problem of different syntax as well). But I would go for standardise to something like host_ndx_selection and host_boresch_selection.

For example on gmx_MMPBSA if some cofactors would like to be included in the calculation, we can use host_name=Protein or resname yCA or resname COF, and this will be internally converted to group Protein or resname COF, but the addition of the group keyword is hidden and prompt to confusion on the user end. Better that users are in total charge and aware to use a full-valid gmx make_ndx. This fix will break the workflow because of the call of center_xtc on the mmpbsa workflow that uses host_name

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions