Empty files inside PSP archives are not handled properly

[lemonadecbc]

This is propably due to how file identification is handled, empty files do not have size or checksums causing them not to be identified properly when using import-roms.

For example some of the PSP rom "Kidou Senshi Gundam - Gihren no Yabou - Axis no Kyoui V (Japan) [T-En by GihrensTranslator v8] [PPSSPP Gihren Type 24 win64]" contains file "assets\debugger\ .nojekyll", which oxyoromon identifies as missing but if you try to import it, it says it already exists.

Due to this, these roms cannot be imported 100% as they should be, but these empty files are left out.

[alucryd]

Thanks for the report, I'll probably need to handle these separately from regular files.

[lemonadecbc]

Yes, I agree. I would say that you only need to check that size is zero and filename matches the dat-file instead of checking hash checksum at all. However, this special treatment should not be necessary for any files that have file size bigger than 0 as those should be verified against sha/md5 hash.

[alucryd]

@lemonadecbc First attempt at solving this: 4cba076

Empty files are simply deleted when imported, then when computing a system completion, partial games will have these empty files automatically created. This does not take into account the format of the game yet, it creates a file whether the game is inside an archive or not, so convert-roms is needed. If you have time to give this first attempt a try, that would be great. Then we can see how to refine it.

[lemonadecbc]

Ok, importing now worked, but with this version it seems that if I choose "None" option for import-roms that require choosing ROM from a list gives error:

"thread 'main' panicked at src/import_roms.rs:2357:47:
called Option::unwrap() on a None value
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace"

It might not be related to this change, didn't test if same happens with parent 4037b3d too or not. Going to do some more testing with this change and report here is any issues occur. Thanks for this update!