PL Functions - ALTER FUNCTION

[Posdiver]

First - thanks for the tool.

I've started to try it out this morning and so far it's quite nice - we added our own Sequence definition delta tool since your tools does not seem to support it (only values).

We have a bug though when comparing functions (PL in our case) - the function definition is alright but the ALTER FUNCTION command has a glitch, it adds the param definition 2 times:

ex:
ALTER FUNCTION public.se2_isnumeric(text)(text) OWNER TO XXX;
instead of having
ALTER FUNCTION public.se2_isnumeric(text) OWNER TO XXX;

Let me know if you think you can fix that in the coming days - if not we will build our own.

Regards
Frank

[andrea-latini]

Hi Frank,
thanks for your feedback.
Sorry but we are not able to reproduce your bug; maybe it is generated from different version or settings of Postgresql?
That command is generated from this part of code:
_sqls.push('ALTER FUNCTION ' + _f1.name + '(' + _f1.args + ') OWNER TO ' + options.owner)

so maybe in your case the name of the function already contains the arguments? That values are taken by the "getFunctions" function in the file Schema.js.
If you could check it and then fix it, we have the pleasure of accepting your fix.

Regards
Andrea

[Posdiver]

We're on the v10 of PG... Maybe that's the reason. I saw that we did had access to source code and yeah I already did the fix by removing the f1 args... Args definition is indeed in the name. Thanks for your reply On Feb 23, 2018 05:05, "andrea-latini" <notifications@github.com> wrote: Hi Frank, thanks for your feedback. Sorry but we are not able to reproduce your bug; maybe it is generated from different version or settings of Postgresql? That command is generated from this part of code: // / add function owner _sqls.push('ALTER FUNCTION ' + _f1.name + '(' + _f1.args + ') OWNER TO ' + options.owner) so maybe in your case the name of the function already contains the arguments? That values are taken by the "getFunctions" function in the file Schema.js. If you could check it and then fix it, we have the pleasure of accepting your fix. Regards Andrea — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASg4EDMqvgtIkzqtMFnCv6bqGkmQodSeks5tXo1ZgaJpZM4SP1MD> .