From 3085c38de98b2952d521eb0b6715512aef931909 Mon Sep 17 00:00:00 2001 From: Krystian Hebel Date: Tue, 2 Sep 2025 11:30:08 +0200 Subject: [PATCH 1/3] Don't use example.org for testing network It fails in CI tests, either because this site has blocked access from GitHub servers, or due to intermittent network issue outside of our control. Use github.com instead, since we're relying on it for CI anyway. Ping doesn't work in GHA by design, hence wget is still used: https://github.com/actions/runner-images/issues/1519#issuecomment-683790054 Signed-off-by: Krystian Hebel --- .github/workflows/pull-request.yml | 4 ++-- .github/workflows/release.yml | 6 +++--- .github/workflows/run-locally.yml | 2 +- README.md | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 3668b20..203eb9c 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -79,7 +79,7 @@ jobs: kernel: artifact/kernel-riscv64-hifive_unleashed.tar.xz image: artifact/image-riscv64-default.tar.xz renode-run: | - wget example.org + wget --spider github.com sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md @@ -112,7 +112,7 @@ jobs: kernel: artifact/kernel-arm32-zynq_7000.tar.xz image: artifact/image-arm32-default.tar.xz renode-run: | - wget example.org + wget --spider github.com sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9852b50..f97bed1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -131,7 +131,7 @@ jobs: with: shared-dirs: tests renode-run: | - wget example.org + wget --spider github.com sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md @@ -214,7 +214,7 @@ jobs: arch: arm32 shared-dirs: tests renode-run: | - wget example.org + wget --spider github.com sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md @@ -282,7 +282,7 @@ jobs: renode-run: | should-fail: true commands: - - "wget example.org" + - "wget --spider github.com" custom-task-test: runs-on: ubuntu-latest diff --git a/.github/workflows/run-locally.yml b/.github/workflows/run-locally.yml index 0a0b2d8..e1b46c0 100644 --- a/.github/workflows/run-locally.yml +++ b/.github/workflows/run-locally.yml @@ -18,7 +18,7 @@ jobs: with: shared-dirs: tests renode-run: | - wget example.org + wget --spider github.com sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md diff --git a/README.md b/README.md index 5c86b57..57822bd 100644 --- a/README.md +++ b/README.md @@ -89,7 +89,7 @@ You can also set additional test parameters with [Task files](#tasks). For examp renode-run: | - should-fail: true - commands: - - wget example.org + - wget --spider github.com ``` This test will complete successfully because the network is disabled in the emulated system and `wget` will return a non-zero exit code. From 49f6d709e960853ce750c56991bc84454bc5caf5 Mon Sep 17 00:00:00 2001 From: Krystian Hebel Date: Tue, 2 Sep 2025 16:54:46 +0200 Subject: [PATCH 2/3] Work around wget without HTTPS support Signed-off-by: Krystian Hebel --- .github/workflows/pull-request.yml | 4 ++-- .github/workflows/release.yml | 6 +++--- .github/workflows/run-locally.yml | 2 +- README.md | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 203eb9c..54ff605 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -79,7 +79,7 @@ jobs: kernel: artifact/kernel-riscv64-hifive_unleashed.tar.xz image: artifact/image-riscv64-default.tar.xz renode-run: | - wget --spider github.com + wget --spider -S github.com 2>&1 | grep "301 Moved Permanently" sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md @@ -112,7 +112,7 @@ jobs: kernel: artifact/kernel-arm32-zynq_7000.tar.xz image: artifact/image-arm32-default.tar.xz renode-run: | - wget --spider github.com + wget --spider -S github.com 2>&1 | grep "301 Moved Permanently" sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f97bed1..da9f59f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -131,7 +131,7 @@ jobs: with: shared-dirs: tests renode-run: | - wget --spider github.com + wget --spider -S github.com 2>&1 | grep "301 Moved Permanently" sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md @@ -214,7 +214,7 @@ jobs: arch: arm32 shared-dirs: tests renode-run: | - wget --spider github.com + wget --spider -S github.com 2>&1 | grep "301 Moved Permanently" sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md @@ -282,7 +282,7 @@ jobs: renode-run: | should-fail: true commands: - - "wget --spider github.com" + - wget --spider -S github.com 2>&1 | grep "301 Moved Permanently" custom-task-test: runs-on: ubuntu-latest diff --git a/.github/workflows/run-locally.yml b/.github/workflows/run-locally.yml index e1b46c0..9f8c04a 100644 --- a/.github/workflows/run-locally.yml +++ b/.github/workflows/run-locally.yml @@ -18,7 +18,7 @@ jobs: with: shared-dirs: tests renode-run: | - wget --spider github.com + wget --spider -S github.com 2>&1 | grep "301 Moved Permanently" sh gpio.sh sh i2c.sh python pyrav4l2/.github/save_examples.py pyrav4l2/README.md diff --git a/README.md b/README.md index 57822bd..9d2ee16 100644 --- a/README.md +++ b/README.md @@ -89,7 +89,7 @@ You can also set additional test parameters with [Task files](#tasks). For examp renode-run: | - should-fail: true - commands: - - wget --spider github.com + - wget --spider -S github.com 2>&1 | grep "301 Moved Permanently" ``` This test will complete successfully because the network is disabled in the emulated system and `wget` will return a non-zero exit code. From 13a731d3ec4e890fc4a574a3c12e590b83d30f1f Mon Sep 17 00:00:00 2001 From: Krystian Hebel Date: Tue, 2 Sep 2025 17:56:49 +0200 Subject: [PATCH 3/3] Fix download-artifact parameters for pr-arm32-test Signed-off-by: Krystian Hebel --- .github/workflows/pull-request.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 54ff605..00c6e80 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -102,7 +102,9 @@ jobs: - uses: actions/download-artifact@v4 with: - path: ./ + path: artifact/ + pattern: artifact-* + merge-multiple: true - name: test uses: ./