From ed8dca695d4da7d2f54c224cb2780e40b8fb9251 Mon Sep 17 00:00:00 2001 From: Alexis THOMAS Date: Sat, 12 Feb 2022 18:48:36 +0100 Subject: [PATCH 1/2] test: fix failure when run on Windows path mismatch because of platform-specific path separator From "FAILURES: 2/1599 assertions failed" To "OK: 1599 assertions" --- test/addTarget.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/addTarget.js b/test/addTarget.js index 2ad819a9..7b05bf05 100644 --- a/test/addTarget.js +++ b/test/addTarget.js @@ -17,6 +17,7 @@ var fullProject = require('./fixtures/full-project') fullProjectStr = JSON.stringify(fullProject), + path = require('path'), pbx = require('../lib/pbxProject'), pbxFile = require('../lib/pbxFile'), proj = new pbx('.'); @@ -138,7 +139,7 @@ exports.addTarget = { test.equal(debugConfig[0], '"DEBUG=1"'); test.equal(debugConfig[1], '"$(inherited)"'); } - test.equal(pbxConfig.buildSettings['INFOPLIST_FILE'], '"' + TARGET_SUBFOLDER_NAME + '/' + TARGET_SUBFOLDER_NAME + '-Info.plist"'); + test.equal(pbxConfig.buildSettings['INFOPLIST_FILE'], '"' + TARGET_SUBFOLDER_NAME + path.sep + TARGET_SUBFOLDER_NAME + '-Info.plist"'); test.equal(pbxConfig.buildSettings['LD_RUNPATH_SEARCH_PATHS'], '"$(inherited) @executable_path/Frameworks @executable_path/../../Frameworks"'); test.equal(pbxConfig.buildSettings['PRODUCT_NAME'], '"' + TARGET_NAME + '"'); test.equal(pbxConfig.buildSettings['SKIP_INSTALL'], 'YES'); From 50d9e0c4fc31090c7740c89ef94e6b2d1d8a3005 Mon Sep 17 00:00:00 2001 From: Alexis THOMAS Date: Sat, 12 Feb 2022 18:49:18 +0100 Subject: [PATCH 2/2] style: minor line formats --- test/addTarget.js | 2 +- test/pbxFile.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/addTarget.js b/test/addTarget.js index 7b05bf05..7c26cd4f 100644 --- a/test/addTarget.js +++ b/test/addTarget.js @@ -110,7 +110,7 @@ exports.addTarget = { test.ok(target.pbxNativeTarget.buildPhases); test.ok(target.pbxNativeTarget.buildRules); test.ok(target.pbxNativeTarget.dependencies); - + test.done(); }, 'should add debug and release configurations to build configuration list': function (test) { diff --git a/test/pbxFile.js b/test/pbxFile.js index 4f0d1a2f..48b894fe 100644 --- a/test/pbxFile.js +++ b/test/pbxFile.js @@ -230,7 +230,7 @@ exports['path'] = { } exports['settings'] = { - 'should not be defined by default': function (test) { + 'should not be defined by default': function (test) { var sourceFile = new pbxFile('social.framework'); test.equal(undefined, sourceFile.settings);