From a7cbbec3f320541a00ef8051aeaa913241f0571a Mon Sep 17 00:00:00 2001 From: Werner Punz Date: Thu, 5 Jun 2025 20:12:32 +0200 Subject: [PATCH] https://issues.apache.org/jira/browse/MYFACES-4719: Fix for event type not being rendered in command script call --- .../myfaces/renderkit/html/HtmlCommandScriptRenderer.java | 2 +- .../apache/myfaces/renderkit/html/util/AjaxScriptBuilder.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlCommandScriptRenderer.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlCommandScriptRenderer.java index 926f85c112..efc7e347e2 100644 --- a/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlCommandScriptRenderer.java +++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlCommandScriptRenderer.java @@ -80,7 +80,7 @@ public void encodeBegin(FacesContext context, UIComponent component) throws IOEx script.prettyLine(); script.increaseIndent(); - script.append("var "+name+" = function(o){var o=(typeof o==='object')&&o?o:{};"); + script.append("var "+name+" = function(o, event){var o=(typeof o==='object')&&o?o:{};"); script.prettyLine(); List uiParams = HtmlRendererUtils.getValidUIParameterChildren( diff --git a/impl/src/main/java/org/apache/myfaces/renderkit/html/util/AjaxScriptBuilder.java b/impl/src/main/java/org/apache/myfaces/renderkit/html/util/AjaxScriptBuilder.java index fd78096069..0da2e73ecd 100644 --- a/impl/src/main/java/org/apache/myfaces/renderkit/html/util/AjaxScriptBuilder.java +++ b/impl/src/main/java/org/apache/myfaces/renderkit/html/util/AjaxScriptBuilder.java @@ -178,7 +178,7 @@ public static void build(FacesContext context, } sb.append(','); - sb.append(commandScript == null ? AJAX_VAL_EVENT : AJAX_VAL_NULL); + sb.append(AJAX_VAL_EVENT); sb.append(",'"); sb.append(eventName);