If Imagemagick lib is missing locally, failure mode is pretty harsh

[starsinmypockets]

description

If the uploadfs consumer is trying to use imagemagick backend without the imagemagick library installed locally, the current implementation falls back to jimp (whatever Jimp is!) and jimp just Borks... for me at least. The resulting callstack does little to help troubleshoot the error... for me at least.

steps to reproduce

I hit this using https://github.com/apostrophecms/apostrophe-enterprise-testbed but should be easy to reproduce by running the tests locally without imagemagick installed.

Action

Probably we should catch this error and offer a polite explanation that the imagemagick library needs to be installed in order to use the imagemagick backend. Maybe even a link to the installation instructions if we're feeling generous ;)

[boutell]

Jimp is borking for your SVG file testing, which is a new thing. Jimp works fine for JPEG, PNG and in the latest release of uploadfs, GIF as well (first frame only). So this is not quite as urgent as written, it is a follow-on after we get svg working with the "imagemagick" backend.

…

On Fri, Jun 1, 2018 at 9:00 AM, Paul Walker ***@***.***> wrote: description If the uploadfs consumer is trying to use imagemagick backend without the imagemagick library installed locally, the current implementation falls back to jimp (whatever Jimp is!) and jimp just Borks... for me at least. The resulting callstack does little to help troubleshoot the error... for me at least. steps to reproduce I hit this using https://github.com/apostrophecms/apostrophe- enterprise-testbed but should be easy to reproduce by running the tests locally without imagemagick installed. Action Probably we should catch this error and offer a polite explanation that the imagemagick library needs to be installed in order to use the imagemagick backend. Maybe even a link to the installation instructions if we're feeling generous ;) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#42>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB9fRIV83B3-Ik2uXmxk3PH_eP_e_Rfks5t4TrYgaJpZM4UWqRk> .

-- *THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT* P'UNK AVENUE | (215) 755-1330 | punkave.com

[boutell]

Also the fallback doesn't happen if the backend has been set explicitly, you're describing an issue with the default "try to figure out what they have" behavior. I think. Unless you *are* configuring it explicitly.

…

On Fri, Jun 1, 2018 at 9:01 AM, Tom Boutell ***@***.***> wrote: Jimp is borking for your SVG file testing, which is a new thing. Jimp works fine for JPEG, PNG and in the latest release of uploadfs, GIF as well (first frame only). So this is not quite as urgent as written, it is a follow-on after we get svg working with the "imagemagick" backend. On Fri, Jun 1, 2018 at 9:00 AM, Paul Walker ***@***.***> wrote: > description > > If the uploadfs consumer is trying to use imagemagick backend without > the imagemagick library installed locally, the current implementation falls > back to jimp (whatever Jimp is!) and jimp just Borks... for me at least. > The resulting callstack does little to help troubleshoot the error... for > me at least. > steps to reproduce > > I hit this using https://github.com/apostrophecms/apostrophe-enterprise- > testbed but should be easy to reproduce by running the tests locally > without imagemagick installed. > Action > > Probably we should catch this error and offer a polite explanation that > the imagemagick library needs to be installed in order to use the > imagemagick backend. Maybe even a link to the installation instructions if > we're feeling generous ;) > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#42>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAB9fRIV83B3-Ik2uXmxk3PH_eP_e_Rfks5t4TrYgaJpZM4UWqRk> > . > -- *THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT* P'UNK AVENUE | (215) 755-1330 | punkave.com

-- *THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT* P'UNK AVENUE | (215) 755-1330 | punkave.com

[starsinmypockets]

Probably need better steps to reproduce.