-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
statement-compatibilityClient-side statement and system variable compatibility with java-spanner/go-sql-spannerClient-side statement and system variable compatibility with java-spanner/go-sql-spanner
Description
Rename CLI_DIRECT_READ to DIRECTED_READ and make read/write
Context
Part of #47 (java-spanner compatibility). Currently CLI_DIRECTED_READ is a read-only variable with a name that was previously a typo (CLI_DIRECT_READ). It needs to match the upstream DIRECTED_READ name and support read/write access.
Upstream References
- java-spanner (
ClientSideStatements.json):DIRECTED_READwith SET/SHOW support (read/write) - go-sql-spanner: Not present as a runtime variable (ExecOptions only)
Changes Required
Variable Rename
- Rename
CLI_DIRECTED_READ→DIRECTED_READ - Drop
CLI_prefix to match java-spanner naming
Make Read/Write
- Currently read-only (set only via
--directed-readCLI flag) - Add SET support: reuse
parseDirectedReadOption()fromsession.goas setter parser - Keep SHOW support
CLI Flag
- Keep
--directed-readCLI flag working (sets initial value)
Backward Compatibility
- No backward compatibility required per project philosophy
Acceptance Criteria
-
SET DIRECTED_READ = '...'works with directed read option string -
SHOW VARIABLE DIRECTED_READworks -
--directed-readCLI flag still works -
CLI_DIRECTED_READis fully removed -
make checkpasses
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
statement-compatibilityClient-side statement and system variable compatibility with java-spanner/go-sql-spannerClient-side statement and system variable compatibility with java-spanner/go-sql-spanner