-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
statement-compatibilityClient-side statement and system variable compatibility with java-spanner/go-sql-spannerClient-side statement and system variable compatibility with java-spanner/go-sql-spanner
Description
Rename CLI_PROTO_DESCRIPTOR_FILE to PROTO_DESCRIPTORS_FILE_PATH
Context
Part of #47 (java-spanner compatibility). Currently CLI_PROTO_DESCRIPTOR_FILE needs to be renamed to match the upstream PROTO_DESCRIPTORS_FILE_PATH name.
Upstream References
- java-spanner (
ClientSideStatements.json):PROTO_DESCRIPTORS_FILE_PATHwith SET/SHOW support - go-sql-spanner: Not present
Changes Required
Variable Rename
- Rename
CLI_PROTO_DESCRIPTOR_FILE→PROTO_DESCRIPTORS_FILE_PATH - Drop
CLI_prefix and align with java-spanner naming
Keep spanner-mycli Extensions
- Keep ADD support (append descriptor files)
- Keep
.protocompilation support - Keep HTTP URL support
Backward Compatibility
- No backward compatibility required per project philosophy
Acceptance Criteria
-
SET PROTO_DESCRIPTORS_FILE_PATH = '...'works -
SHOW VARIABLE PROTO_DESCRIPTORS_FILE_PATHworks - ADD support still works
-
.protocompilation still works - HTTP URL support still works
-
CLI_PROTO_DESCRIPTOR_FILEis fully removed -
make checkpasses
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
statement-compatibilityClient-side statement and system variable compatibility with java-spanner/go-sql-spannerClient-side statement and system variable compatibility with java-spanner/go-sql-spanner