From 52bf53ad23ee7035e3f0366224b64beaa42d523d Mon Sep 17 00:00:00 2001 From: apstndb <803393+apstndb@users.noreply.github.com> Date: Mon, 23 Feb 2026 03:05:00 +0900 Subject: [PATCH 1/2] docs: update review workflow skills and Gemini style guide - review-cycle: expand from delegation to autonomous workflow that detects, fixes, explains, or acknowledges each thread type, then loops until clean - review-respond: add reply content guidelines with concrete examples, improve response strategy documentation - styleguide: add "Avoid Praise-Only Comments" rule to reduce review noise from non-actionable threads Co-Authored-By: Claude Opus 4.6 --- .claude/commands/review-cycle.md | 37 +++++++++++++++++++++++++++++- .claude/commands/review-respond.md | 31 ++++++++++++++----------- .gemini/styleguide.md | 6 ++++- 3 files changed, 58 insertions(+), 16 deletions(-) diff --git a/.claude/commands/review-cycle.md b/.claude/commands/review-cycle.md index 49850849..412d2003 100644 --- a/.claude/commands/review-cycle.md +++ b/.claude/commands/review-cycle.md @@ -18,4 +18,39 @@ Please execute the following steps: 2. Check for unresolved threads: !go tool gh-helper reviews fetch --unresolved-only -3. If there are unresolved threads, please help me address the feedback and then use `/project:review-respond` to reply to all threads. \ No newline at end of file +3. If there are no unresolved threads, report that the review cycle is clean and stop here. + +4. If there are unresolved threads, address each one: + +For each unresolved thread, evaluate the feedback and choose a response strategy: + +- **Code fix needed**: Make the fix in code, then continue to step 5. +- **Explanation only** (no code change needed): Reply with reasoning why current code is correct, resolve, and move to the next thread. +- **Praise/positive comment**: Acknowledge briefly (e.g., "Thank you!") and resolve. + +**Reply content guidelines — always write a meaningful reply:** +- Do NOT just post a commit hash. Explain what was changed and why. +- For code fixes: Describe the specific change made to address the feedback (e.g., "Removed the redundant nil check — `ListVariables()` calls `ensureRegistry()` internally, so the explicit guard was unnecessary and could prevent first-use initialization.") +- For explanations: Provide concrete reasoning, not just "this is intentional." +- Keep it concise but substantive: 1-3 sentences is ideal. + +Thread reply examples: +```bash +# Code fix — explain what was changed +go tool gh-helper threads reply THREAD_ID --commit-hash abc123 --resolve \ + --message "Removed the redundant nil check. ListVariables() calls ensureRegistry() internally, so the explicit guard was preventing first-use initialization." + +# Explanation only — provide reasoning +go tool gh-helper threads reply THREAD_ID --resolve \ + --message "This is intentional: the regex requires \\s+ after SET to avoid matching bare SET as a variable context, which would conflict with other SET usages." + +# Acknowledge praise +go tool gh-helper threads reply THREAD_ID --message "Thank you!" --resolve +``` + +5. After addressing all threads with code changes, commit and push the fixes. + +6. After push and resolve, request a new review to re-validate: +!go tool gh-helper reviews wait --request-review + +7. Repeat from step 2 until there are no unresolved threads. diff --git a/.claude/commands/review-respond.md b/.claude/commands/review-respond.md index c4b259c2..d316afaf 100644 --- a/.claude/commands/review-respond.md +++ b/.claude/commands/review-respond.md @@ -1,7 +1,7 @@ --- name: Review Respond description: Reply to all review threads with commit hash and resolve -arguments: "[commit-message]" +arguments: "[commit_message]" --- # Respond to Review Threads @@ -17,38 +17,41 @@ After addressing review feedback, please: 2. Find all unresolved threads (including outdated ones) and respond to each one: !go tool gh-helper reviews fetch --unresolved-only -For each thread ID found above, reply with the CORRECT commit hash where that specific issue was fixed and resolve it, regardless of whether it's marked as outdated. +For each thread ID found above, reply and resolve it, regardless of whether it's marked as outdated. + +**Reply content guidelines — always write a meaningful reply:** +- Do NOT just post a commit hash. Explain what was changed and why. +- For code fixes: Describe the specific change made to address the feedback. +- For explanations: Provide concrete reasoning, not just "this is intentional." +- Keep it concise but substantive: 1-3 sentences is ideal. **Response strategy per thread type:** -- **Code fix needed**: Make the fix, commit, then reply with commit hash and resolve +- **Code fix needed**: Make the fix, commit, then reply with commit hash and explanation, and resolve - **Explanation only** (no code change needed): Reply with reasoning why current code is correct, then resolve - **Praise/positive comment**: Acknowledge briefly (e.g., "Thank you!") and resolve — don't leave these unresolved -When replying to threads, include a brief explanation of the fix: -- Use `--message "Brief explanation of what was fixed"` for single-line responses -- For multi-line responses, use stdin with heredoc -- Default format: "Fixed in [commit-hash] - [brief explanation]$ARGUMENTS" - Examples: ```bash -# Single-line response -go tool gh-helper threads reply THREAD_ID --commit-hash abc123 --message "Fixed by making CLI_SKIP_SYSTEM_COMMAND read-only" --resolve +# Code fix — explain what was changed +go tool gh-helper threads reply THREAD_ID --commit-hash abc123 --resolve \ + --message "Removed the redundant nil check. ListVariables() calls ensureRegistry() internally, so the explicit guard was preventing first-use initialization." # Multi-line response for complex fixes cat < Date: Mon, 23 Feb 2026 05:38:24 +0900 Subject: [PATCH 2/2] fix: clarify review-cycle step 6 to explicitly reply & resolve threads Address Gemini review feedback: step 6 now explicitly states to reply to and resolve code-fix threads with the new commit hash before requesting a re-review, preventing potential infinite loops. Co-Authored-By: Claude Opus 4.6 --- .claude/commands/review-cycle.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.claude/commands/review-cycle.md b/.claude/commands/review-cycle.md index 412d2003..41bf924f 100644 --- a/.claude/commands/review-cycle.md +++ b/.claude/commands/review-cycle.md @@ -50,7 +50,7 @@ go tool gh-helper threads reply THREAD_ID --message "Thank you!" --resolve 5. After addressing all threads with code changes, commit and push the fixes. -6. After push and resolve, request a new review to re-validate: +6. With the new commit hash, reply to and resolve all code-fix threads, then request a new review to re-validate: !go tool gh-helper reviews wait --request-review 7. Repeat from step 2 until there are no unresolved threads.