Improve diff visualization with colored triangles and thicker lines#77
Improve diff visualization with colored triangles and thicker lines#77mircealungu wants to merge 2 commits intomasterfrom
Conversation
Replace parenthetical (+N)/(-N) dependency change indicators with colored triangle symbols: green ▲ for increases, red ▼ for decreases. Also increase the thickness of colored diff lines to 2px for better visibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
ArchLens - No architecturally relevant changes to the existing views |
…theses - Move triangle indicator to new line below dependency count - Make indicator text smaller (size 10) and bold - Wrap indicator in parentheses for clarity 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Ehi @SebastianHylander and @casperh123 - would this changes interfere with the extension in any way? The goal is to render the diff edges thicker and the deltas with triangles like the stock tickers :) 
|
casperh123
left a comment
casperh123
left a comment
There was a problem hiding this comment.
I think these changes are safe to implement. After looking around in the extension code i don't see that these changes should break anything, but they might change how the graph is rendered in the extension aswell
| diff_indicator = f"<size:10><b><color:red>(▼{abs(diff)})</color></b></size>" | ||
| dependency_count = ( | ||
| f"{local_value.dependency_count} ({sign}{diff})" | ||
| f"{local_value.dependency_count}\\n{diff_indicator}" |
There was a problem hiding this comment.
This will be probably change the indicator for the extension as well. That might actually be what we want do, since it aligns the interfaces?
| "to_package": remote_value.to_package, | ||
| "color": color, | ||
| "label": f"0 ({dependency_count})", | ||
| "label": f"0\\n<size:10><b><color:red>(▼{abs(dependency_count)})</color></b></size>", |
There was a problem hiding this comment.
This will probably also just change how the extension renders the graph, but i don't think it is a breaking change.
2 participants
Summary
(+N)and(-N)dependency change indicators with colored triangle symbols: green ▲ for increases, red ▼ for decreasesTest plan
archlens render-diffon a project with dependency changes🤖 Generated with Claude Code