Badge images missing ?

[ashmckenzie]

The following badge images are missing :(

[
"50_github_issues_opened",
"100_github_issues_opened",
"500_github_issues_opened",
"50_github_issues_closed",
"100_github_issues_closed",
"500_github_issues_closed",
"25_pager_duty_acks",
"50_pager_duty_acks"
]

Also,

http://leaderboard.hooroo.com/assets/badges/500_github_pushes.png seems to be missing the 500 part ?

[clouseauu]

Hmmm I'll have a look
On May 20, 2013 7:51 AM, "Ash McKenzie" notifications@github.com wrote:

The following badge images are missing :(

[
"50_github_issues_opened",
"100_github_issues_opened",
"500_github_issues_opened",
"50_github_issues_closed",
"100_github_issues_closed",
"500_github_issues_closed",
"25_pager_duty_acks",
"50_pager_duty_acks"
]

Also,

http://leaderboard.hooroo.com/assets/badges/500_github_pushes.png seems
to be missing the 500 part ?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/21
.

[ashmckenzie]

A few of them appear to be 250 instead of 25 etc..

clouseauu mailto:notifications@github.com
20 May 2013 8:25 AM
Hmmm I'll have a look
On May 20, 2013 7:51 AM, "Ash McKenzie" notifications@github.com wrote:

The following badge images are missing :(

[
"50_github_issues_opened",
"100_github_issues_opened",
"500_github_issues_opened",
"50_github_issues_closed",
"100_github_issues_closed",
"500_github_issues_closed",
"25_pager_duty_acks",
"50_pager_duty_acks"
]

Also,

http://leaderboard.hooroo.com/assets/badges/500_github_pushes.png seems
to be missing the 500 part ?

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/21
.

—
Reply to this email directly or view it on GitHub
#21 (comment).

[clouseauu]

commit 163449b takes care of everything, except for the pager duty ones. According to /app/models/achievement_calculators/calculators/pager_duty_ack.rb, we have:

      def badges
        {
          1    => '1_pager_duty_ack',
          100  => '100_pager_duty_acks',
          250  => '250_pager_duty_acks',
          500  => '500_pager_duty_acks'
        }
      end

So I figured those are the right numbers?

[ashmckenzie]

Legendary work!

[ashmckenzie]

Hmm, good point. What do you guys think ? Too much of a gap between 1
and 100 ? Seems to be around 10 ack's per week, so maybe we should
shift them to

1, 25, 100 and 250 ? Or something like that ?

Ash.

clouseauu mailto:notifications@github.com
20 May 2013 11:27 PM

commit 163449b
163449b takes care
of everything, except for the pager duty ones. According to
/app/models/achievement_calculators/calculators/pager_duty_ack.rb, we
have:

def badges
{
1 => '1_pager_duty_ack',
100 => '100_pager_duty_acks',
250 => '250_pager_duty_acks',
500 => '500_pager_duty_acks'
}
end

So I figured those are the right numbers?

—
Reply to this email directly or view it on GitHub
#21 (comment).

[clouseauu]

Yeah, sounds good. 1,25,100,250 sounds reasonable. I'll change the badges & code at hack arvo.

[ashmckenzie]