Skip to content

AXON-1675: Right-align toggle buttons in Rovo Dev preference menu - (Rovo Dev) #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
atlassian wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −11
Draft

AXON-1675: Right-align toggle buttons in Rovo Dev preference menu - (Rovo Dev) #1414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/rovo-dev/ui/RovoDev.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,7 @@ body {
display: flex;
flex-direction: row;
align-items: flex-start;
justify-content: space-between;
gap: 8px;
background-color: var(--vscode-sideBar-background);
border-radius: 8px;
Expand All @@ -857,6 +858,9 @@ body {

.prompt-settings-action {
--ds-icon-inverse: var(--vscode-sideBar-background);
margin-left: auto;
flex-shrink: 0;
align-self: flex-start;
}

.prompt-settings-logo {
Expand Down
24 changes: 13 additions & 11 deletions src/rovo-dev/ui/prompt-box/prompt-settings-popup/PromptSettingsPopup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,17 +135,19 @@ const PromptSettingsItem: React.FC<{
}> = ({ icon, label, description, action, actionType, toggled, isInternalOnly }) => {
return (
<div className="prompt-settings-item">
<div className="prompt-settings-logo">{icon}</div>
<div id="prompt-settings-context">
<p style={{ fontWeight: 'bold' }}>
{label}
{isInternalOnly && (
<span style={{ backgroundColor: 'var(--vscode-badge-background)', marginLeft: '8px' }}>
Internal only
</span>
)}
</p>
<p style={{ fontSize: '11px' }}>{description}</p>
<div style={{ display: 'flex', alignItems: 'flex-start', gap: '8px', flex: '1' }}>
<div className="prompt-settings-logo">{icon}</div>
<div id="prompt-settings-context" style={{ flex: '1' }}>
Copy link
Contributor Author

@atlassian atlassian bot Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Code Bugs

Remove the id attribute as multiple PromptSettingsItem components render simultaneously, creating duplicate IDs in the DOM which violates HTML standards.

Details

📖 Explanation: The PromptSettingsItem component is rendered multiple times in the popup (for Plan, Full-Context mode, and YOLO settings), but each instance uses the same id="prompt-settings-context". This creates multiple DOM elements with identical IDs, which is invalid HTML and can cause issues with accessibility tools and JavaScript selectors.

Suggested change
<div id="prompt-settings-context" style={{ flex: '1' }}>
<div style={{ flex: '1' }}>

Uses AI. Verify results. Give Feedback

<p style={{ fontWeight: 'bold' }}>
{label}
{isInternalOnly && (
<span style={{ backgroundColor: 'var(--vscode-badge-background)', marginLeft: '8px' }}>
Internal only
</span>
)}
</p>
<p style={{ fontSize: '11px' }}>{description}</p>
</div>
</div>
{action && (
<div className="prompt-settings-action">
Expand Down
Loading