Skip to content

AXON-1869: Stop fetching external images #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwang19-atlassian merged 4 commits into from
Feb 5, 2026
+25 −9
Merged

AXON-1869: Stop fetching external images #1576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83bca91
fix: stop fetching img if it's external
jwang19-atlassian Feb 5, 2026
9641595
fix: external image url in start work
jwang19-atlassian Feb 5, 2026
a1b3176
unit tests
jwang19-atlassian Feb 5, 2026
6b20f66
Merge branch 'main' into axon-1869-ssrf-jira-image-issue
jwang19-atlassian Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/lib/webview/controller/startwork/startWorkWebviewController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,15 +440,7 @@ describe('StartWorkWebviewController', () => {

await controller.onMessageReceived(externalImageAction);

// Note: The implementation has a bug - it should return after posting the empty response,
// but it continues and tries to fetch the external URL
expect(mockTransportFactory.get).toHaveBeenCalledWith('https://external.com/image.png', {
method: 'GET',
headers: {
Authorization: undefined,
},
responseType: 'arraybuffer',
});
expect(mockTransportFactory.get).not.toHaveBeenCalled();
expect(mockMessagePoster).toHaveBeenCalledWith({
type: 'getImageDone',
imgData: '',
Expand Down
1 change: 1 addition & 0 deletions src/lib/webview/controller/startwork/startWorkWebviewController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ export class StartWorkWebviewController implements WebviewController<StartWorkIs
imgData: '',
nonce: msg.nonce,
} as any);
break;
}

const url = href.toString();
Expand Down
22 changes: 22 additions & 0 deletions src/webviews/jiraIssueWebview.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,6 +1716,28 @@ describe('JiraIssueWebview', () => {
});
});

test('should skip external images and not fetch', async () => {
const mockGet = jest.fn().mockResolvedValue({ data: Buffer.from('image-data') });
mockJiraClient.transportFactory.mockReturnValue({ get: mockGet });

const msg = {
action: 'getImage',
url: 'https://external.com/image.png',
nonce: 'nonce-123',
};

const postMessageSpy = jest.spyOn(jiraIssueWebview as any, 'postMessage');

await jiraIssueWebview['onMessageReceived'](msg);

expect(mockGet).not.toHaveBeenCalled();
expect(postMessageSpy).toHaveBeenCalledWith({
type: 'getImageDone',
imgData: '',
nonce: 'nonce-123',
});
});

test('should handle refreshIssue action', async () => {
const msg = { action: 'refreshIssue' };

Expand Down
1 change: 1 addition & 0 deletions src/webviews/jiraIssueWebview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,6 +1882,7 @@ export class JiraIssueWebview
imgData: '',
nonce: msg.nonce,
});
break;
}

const url = href.toString();
Expand Down
Loading